[Core] Avoid status copy #47562
Merged
[Core] Avoid status copy #47562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/avoid-status-copy
branch
from
b955c1c
to
1146b99
Compare
dentiny
commented
Sep 9, 2024
| @@ -49,7 +49,7 @@ class error_code; | |||
| // Return the given status if it is not OK. | |||
| #define RAY_RETURN_NOT_OK(s) \ | |||
| do { \ | |||
| ::ray::Status _s = (s); \ | |||
There was a problem hiding this comment.
The copy happens on critical path;
If passed-in s is a expression, it would be evaluated first, constant reference would do lifecycle extension.
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
force-pushed
the
hjiang/avoid-status-copy
branch
from
1146b99
to
a6b5913
Compare
jjyao
approved these changes
Sep 14, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoid
Statuscopy at propagation macros.Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.