-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Optimizing performance of Ray Dashboard #47617
[Dashboard] Optimizing performance of Ray Dashboard #47617
Conversation
2c90658
to
260f13a
Compare
583d244
to
35a7b4f
Compare
@@ -26,7 +26,7 @@ | |||
"RAY_DASHBOARD_STATS_PURGING_INTERVAL", 60 * 10 | |||
) | |||
RAY_DASHBOARD_STATS_UPDATING_INTERVAL = env_integer( | |||
"RAY_DASHBOARD_STATS_UPDATING_INTERVAL", 2 | |||
"RAY_DASHBOARD_STATS_UPDATING_INTERVAL", 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanwguo if we want to preserve UI update frequency to 2s we'll need to switch to pulling model in the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 15s is probably fine.
@@ -26,7 +26,7 @@ | |||
"RAY_DASHBOARD_STATS_PURGING_INTERVAL", 60 * 10 | |||
) | |||
RAY_DASHBOARD_STATS_UPDATING_INTERVAL = env_integer( | |||
"RAY_DASHBOARD_STATS_UPDATING_INTERVAL", 2 | |||
"RAY_DASHBOARD_STATS_UPDATING_INTERVAL", 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 15s is probably fine.
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
35a7b4f
to
4dc82d5
Compare
For those who might run into this in the future: CI is failing b/c i'm adding module named
|
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Hi, I can often see the following error reported in dashboard.log after upgrading to 2.38.0, and I see that blame is related to this pr, and wanted to ask if it's as expected. @alexeykudinkin
|
@yx367563 I'm able to reproduce it and let me put up a fix really quick. |
@jjyao Please let me know after the fix is completed. I found that after upgrading to Ray 2.38.0, I can no longer get the relevant information of DataSource.nodes in state_manager like DataSource.nodes[node_id]["nodeName"]/DataSource.nodes[node_id]["nodeManagerHostName"]. Is this related to this problem? |
It's just fixed in master. |
@jjyao Thank you! Could you help me to see why can no longer get the relevant information of DataSource.nodes in state_manager like DataSource.nodes[node_id]["nodeName"]/DataSource.nodes[node_id]["nodeManagerHostName"]. Because it's still can get this data in ray 2.23.0 |
@jjyao For now, it just:
You can see that the following data are all invalid data |
It seems you've erased all this information after the node's death. |
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.