Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core][aDAG] Set buffer size to 1 for regression #47639

Merged
merged 5 commits into from
Sep 16, 2024
Merged

[Core][aDAG] Set buffer size to 1 for regression #47639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7cddd0
.
Sep 12, 2024
818221c
Merge branch 'master' into try-reducing-buffer-size
rkooo567 Sep 14, 2024
4e160e6
.
rkooo567 Sep 14, 2024
223337a
.
rkooo567 Sep 14, 2024
ad10b40
fix mistakes
rkooo567 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ray/dag/compiled_dag_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ def __init__(
# We conservatively set num_shm_buffers to _max_inflight_executions.
# It means that the DAG can be underutilized, but it guarantees there's
# no false positive timeouts.
num_shm_buffers=self._max_inflight_executions,
num_shm_buffers=1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the comment above and add a TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this this week, so it may be okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, feel free to merge first if urgent.

)
if not isinstance(self._buffer_size_bytes, int) or self._buffer_size_bytes <= 0:
raise ValueError(
Expand Down
1 change: 1 addition & 0 deletions python/ray/dag/tests/experimental/test_accelerated_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,6 +1970,7 @@ def test_driver_and_actor_as_readers(ray_start_cluster):
dag.experimental_compile()


@pytest.mark.skip("Currently buffer size is set to 1 because of regression.")
@pytest.mark.parametrize("temporary_change_timeout", [1], indirect=True)
def test_buffered_inputs(shutdown_only, temporary_change_timeout):
ray.init()
Expand Down
Loading