-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Fix check failure RAY_CHECK(it != current_tasks_.end()); #47659
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
This reverts commit 2acc718.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach lgtm. lmk when I can review the PR!
@@ -65,7 +66,12 @@ def print_logs(self): | |||
print(content.decode()) | |||
|
|||
|
|||
gcs_network = network(driver="bridge") | |||
ipam_config = docker.types.IPAMConfig( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you comment how this works? (how the poor networking thing works. how often it happens etc.)
Btw, this is very nice to have such config.. will be very useful for unit test
Why are these changes needed?
The check failure can happen under the following sequence of events:
CoreWorker.current_tasks_
.CoreWorker.current_tasks_
.CoreWorker.current_tasks_
again:Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.