[RLlib] Fix/remove some CI tests and many_ppo release test. #47686
+10
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
simonsays1980
approved these changes
Sep 16, 2024
| "num_gpus": 0, | ||
| "num_sgd_iter": 1, | ||
| }, | ||
| "stop": { | ||
| "timesteps_total": 1, | ||
| NUM_ENV_STEPS_SAMPLED_LIFETIME: 1, |
There was a problem hiding this comment.
Does this mean, we only make quick tests if the class can be built and the algorithm runs?
There was a problem hiding this comment.
Yeah, I guess 🤷 . I think this is a conceptual test for tune to be able to handle large amounts of samples, and not a stress test.
There was a problem hiding this comment.
Thanks for clarifying this :)
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Sep 17, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ect#47686) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/remove some CI tests and many_ppo release test.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.