[Core] Make Object Store memory default ratio env-configurable #47726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykudinkin
requested review from
ericl,
architkulkarni,
hongchaodeng and
a team
as code owners
jjyao
reviewed
Sep 18, 2024
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Made it configurable Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
alexeykudinkin
force-pushed
the
ak/obj-str-mem-cfg-fix
branch
from
757bb0d
to
f12f311
Compare
alexeykudinkin
commented
Sep 20, 2024
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
jjyao
approved these changes
Sep 24, 2024
Comment on lines
906
to
907
| shm_size = ( | ||
| available_memory_bytes * DEFAULT_OBJECT_STORE_MEMORY_PROPORTION * 1.1 |
There was a problem hiding this comment.
No need to change this as we still have the cap.
There was a problem hiding this comment.
Good catch! Reverted
|
Please also update the PR description to reflect the latest code. |
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…roject#47726) Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ratio of available memory allocated to Object Store is hard-coded at 30% which means that for most of the time Ray Data applications are actually not using 70% of memory.
This change
DEFAULT_OBJECT_STORE_MEMORY_PROPORTIONenv-configurableRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.