[core][dashboard] Add Pg Id and Format Required Resources in /logical/actors Response #47754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to Solve
In issue #45658, we found that the placement group id and the required resources are not displayed correctly in the actor UI tab in the dashboard. To be specific:
Root Cause
With investigation, we found the root cause of the issue is that:
Changes in the PR
placementGroupId
in the keys to be translated/preserved in theactor_table_data_to_dict
function so that the pg id can be included in the content of the REST API responseparse_pg_formatted_resources_to_original
function to reformatted the required resources before sending the REST API responsetest_actors
tests to verify the logic of setting the placement group id as well as the correctly formatted required resourcesRelated issue number
#45658
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.