[Train Log]Ray Train Structured Logging #47806

hongpeng-guo · 2024-09-24T06:50:42Z

Why are these changes needed?

This PR creates the structured logging for ray train. The main structure follows the implementation of Ray Data's structured logging PR. Main components include:

python/ray/train/_internal/logging.py: this file defines the logging utility functions;
python/ray/train/tests/test_logging.py: this file provides the corresponding unit tests for the logging utilities.

Example

Code snippet:

import ray
from ray.train import ScalingConfig
from ray.train.torch import TorchTrainer
from ray.train._internal.logging import get_log_directory

import logging
logger = logging.getLogger("ray.train")

ray.init()

def train_func_per_worker():
    logger.info("Training function per worker")

def train_dummy(num_workers=2):
    scaling_config = ScalingConfig(num_workers=num_workers, use_gpu=False)

    trainer = TorchTrainer(
        train_loop_per_worker=train_func_per_worker,
        scaling_config=scaling_config,
    )

    result = trainer.fit()
    print(f"Training result: {result}")

if __name__ == "__main__":
    print(f"Log directory: {get_log_directory()}")
    train_dummy()

JSON Logging

RAY_TRAIN_LOG_ENCODING="JSON" python log.py

{"asctime": "2024-11-01 14:42:01,772", "levelname": "DEBUG", "message": "StorageContext on SESSION (rank=None):\nStorageContext<\n  storage_filesystem='local',\n  storage_fs_path='/Users/hpguo/ray_results',\n  experiment_dir_name='TorchTrainer_2024-11-01_14-42-00',\n  trial_dir_name='TorchTrainer_1ff8a_00000_0_2024-11-01_14-42-00',\n  current_checkpoint_index=-1,\n>", "filename": "session.py", "lineno": 154, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fffffffffffffffffa30a41e3d1adbcbe21f0b7c01000000"}
{"asctime": "2024-11-01 14:42:01,772", "levelname": "DEBUG", "message": "Changing the working directory to: /tmp/ray/session_2024-11-01_14-41-58_674237_12567/artifacts/2024-11-01_14-42-00/TorchTrainer_2024-11-01_14-42-00/working_dirs/TorchTrainer_1ff8a_00000_0_2024-11-01_14-42-00", "filename": "session.py", "lineno": 231, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fffffffffffffffffa30a41e3d1adbcbe21f0b7c01000000"}
{"asctime": "2024-11-01 14:42:01,784", "levelname": "DEBUG", "message": "Starting 2 workers.", "filename": "worker_group.py", "lineno": 202, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fa78bc53cbcd3906b97af0a2c723c9306db701aa01000000"}
{"asctime": "2024-11-01 14:42:02,464", "levelname": "DEBUG", "message": "2 workers have successfully started.", "filename": "worker_group.py", "lineno": 204, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fa78bc53cbcd3906b97af0a2c723c9306db701aa01000000"}
{"asctime": "2024-11-01 14:42:03,296", "levelname": "DEBUG", "message": "Setting up process group for: env:// [rank=1, world_size=2]", "filename": "config.py", "lineno": 88, "job_id": "01000000", "worker_id": "d6f9fed0728edd8b2e6ccfef40e940342871b55f65108a1b3d1935ce", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "e29110a539fe0ce526aae31501000000", "task_id": "b99edc226fd7de6ae29110a539fe0ce526aae31501000000"}
{"asctime": "2024-11-01 14:42:03,297", "levelname": "DEBUG", "message": "using gloo", "filename": "config.py", "lineno": 92, "job_id": "01000000", "worker_id": "d6f9fed0728edd8b2e6ccfef40e940342871b55f65108a1b3d1935ce", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "e29110a539fe0ce526aae31501000000", "task_id": "b99edc226fd7de6ae29110a539fe0ce526aae31501000000"}
{"asctime": "2024-11-01 14:42:03,297", "levelname": "INFO", "message": "Setting up process group for: env:// [rank=0, world_size=2]", "filename": "config.py", "lineno": 83, "job_id": "01000000", "worker_id": "143d46e13a39a6e868d52278b020e1ec26e49458dc6ca2dfe050bfb3", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "9934b6c1b68ac88adfffafca01000000", "task_id": "c8a4749a72b733e29934b6c1b68ac88adfffafca01000000"}
{"asctime": "2024-11-01 14:42:03,297", "levelname": "DEBUG", "message": "using gloo", "filename": "config.py", "lineno": 92, "job_id": "01000000", "worker_id": "143d46e13a39a6e868d52278b020e1ec26e49458dc6ca2dfe050bfb3", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "9934b6c1b68ac88adfffafca01000000", "task_id": "c8a4749a72b733e29934b6c1b68ac88adfffafca01000000"}
{"asctime": "2024-11-01 14:42:03,318", "levelname": "INFO", "message": "Started distributed worker processes: \n- (node_id=8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440, ip=127.0.0.1, pid=12614) world_rank=0, local_rank=0, node_rank=0\n- (node_id=8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440, ip=127.0.0.1, pid=12615) world_rank=1, local_rank=1, node_rank=0", "filename": "backend_executor.py", "lineno": 447, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fa78bc53cbcd3906b97af0a2c723c9306db701aa01000000"}
{"asctime": "2024-11-01 14:42:03,347", "levelname": "DEBUG", "message": "StorageContext on SESSION (rank=0):\nStorageContext<\n  storage_filesystem='local',\n  storage_fs_path='/Users/hpguo/ray_results',\n  experiment_dir_name='TorchTrainer_2024-11-01_14-42-00',\n  trial_dir_name='TorchTrainer_1ff8a_00000_0_2024-11-01_14-42-00',\n  current_checkpoint_index=-1,\n>", "filename": "session.py", "lineno": 154, "job_id": "01000000", "worker_id": "143d46e13a39a6e868d52278b020e1ec26e49458dc6ca2dfe050bfb3", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "9934b6c1b68ac88adfffafca01000000", "task_id": "b195c8cb65d475ad9934b6c1b68ac88adfffafca01000000"}
{"asctime": "2024-11-01 14:42:03,347", "levelname": "DEBUG", "message": "StorageContext on SESSION (rank=1):\nStorageContext<\n  storage_filesystem='local',\n  storage_fs_path='/Users/hpguo/ray_results',\n  experiment_dir_name='TorchTrainer_2024-11-01_14-42-00',\n  trial_dir_name='TorchTrainer_1ff8a_00000_0_2024-11-01_14-42-00',\n  current_checkpoint_index=-1,\n>", "filename": "session.py", "lineno": 154, "job_id": "01000000", "worker_id": "d6f9fed0728edd8b2e6ccfef40e940342871b55f65108a1b3d1935ce", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "e29110a539fe0ce526aae31501000000", "task_id": "51fe9f4d40583850e29110a539fe0ce526aae31501000000"}
{"asctime": "2024-11-01 14:42:03,347", "levelname": "DEBUG", "message": "Changing the working directory to: /tmp/ray/session_2024-11-01_14-41-58_674237_12567/artifacts/2024-11-01_14-42-00/TorchTrainer_2024-11-01_14-42-00/working_dirs/TorchTrainer_1ff8a_00000_0_2024-11-01_14-42-00", "filename": "session.py", "lineno": 231, "job_id": "01000000", "worker_id": "143d46e13a39a6e868d52278b020e1ec26e49458dc6ca2dfe050bfb3", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "9934b6c1b68ac88adfffafca01000000", "task_id": "b195c8cb65d475ad9934b6c1b68ac88adfffafca01000000"}
{"asctime": "2024-11-01 14:42:03,347", "levelname": "DEBUG", "message": "Changing the working directory to: /tmp/ray/session_2024-11-01_14-41-58_674237_12567/artifacts/2024-11-01_14-42-00/TorchTrainer_2024-11-01_14-42-00/working_dirs/TorchTrainer_1ff8a_00000_0_2024-11-01_14-42-00", "filename": "session.py", "lineno": 231, "job_id": "01000000", "worker_id": "d6f9fed0728edd8b2e6ccfef40e940342871b55f65108a1b3d1935ce", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "e29110a539fe0ce526aae31501000000", "task_id": "51fe9f4d40583850e29110a539fe0ce526aae31501000000"}
{"asctime": "2024-11-01 14:42:03,348", "levelname": "INFO", "message": "Training function per worker", "filename": "_log.py", "lineno": 12, "world_size": 2, "world_rank": 0, "local_world_size": 0, "local_rank": 2, "node_rank": 0, "job_id": "01000000", "worker_id": "143d46e13a39a6e868d52278b020e1ec26e49458dc6ca2dfe050bfb3", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "9934b6c1b68ac88adfffafca01000000", "task_id": "b0afaa137412fbc0f3140d3262f7958a2ab66f6101000000"}
{"asctime": "2024-11-01 14:42:03,348", "levelname": "INFO", "message": "Training function per worker", "filename": "_log.py", "lineno": 12, "world_size": 2, "world_rank": 1, "local_world_size": 1, "local_rank": 2, "node_rank": 0, "job_id": "01000000", "worker_id": "d6f9fed0728edd8b2e6ccfef40e940342871b55f65108a1b3d1935ce", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "e29110a539fe0ce526aae31501000000", "task_id": "76ae67616ee4fe95a95e77da9b57b3b753efbf5301000000"}
{"asctime": "2024-11-01 14:42:04,563", "levelname": "DEBUG", "message": "Shutting down 2 workers.", "filename": "worker_group.py", "lineno": 216, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fa78bc53cbcd3906b97af0a2c723c9306db701aa01000000"}
{"asctime": "2024-11-01 14:42:04,571", "levelname": "DEBUG", "message": "Graceful termination failed. Falling back to force kill.", "filename": "worker_group.py", "lineno": 225, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fa78bc53cbcd3906b97af0a2c723c9306db701aa01000000"}
{"asctime": "2024-11-01 14:42:04,572", "levelname": "DEBUG", "message": "Shutdown successful.", "filename": "worker_group.py", "lineno": 230, "job_id": "01000000", "worker_id": "fbb4d4ba1a20870da058447259990e6b9feb17045e59aef3db06bb41", "node_id": "8bb78ec9d3c95a59e53764d8510d5b669918f128ac8da7d1c4b4d440", "actor_id": "fa30a41e3d1adbcbe21f0b7c01000000", "task_id": "fa78bc53cbcd3906b97af0a2c723c9306db701aa01000000"}

Text Logging

RAY_TRAIN_LOG_ENCODING="TEXT" python log.py

2024-09-24 15:06:02,274	DEBUG session.py:154 -- StorageContext on SESSION (rank=None):
StorageContext<
  storage_filesystem='local',
  storage_fs_path='/Users/hpguo/ray_results',
  experiment_dir_name='TorchTrainer_2024-09-24_15-06-00',
  trial_dir_name='TorchTrainer_2edb7_00000_0_2024-09-24_15-06-00',
  current_checkpoint_index=-1,
>
2024-09-24 15:06:02,274	DEBUG session.py:231 -- Changing the working directory to: /tmp/ray/session_2024-09-24_15-05-58_999739_31907/artifacts/2024-09-24_15-06-00/TorchTrainer_2024-09-24_15-06-00/working_dirs/TorchTrainer_2edb7_00000_0_2024-09-24_15-06-00
2024-09-24 15:06:02,286	DEBUG worker_group.py:202 -- Starting 2 workers.
2024-09-24 15:06:02,973	DEBUG worker_group.py:204 -- 2 workers have successfully started.
2024-09-24 15:06:03,812	INFO config.py:83 -- Setting up process group for: env:// [rank=0, world_size=2]
2024-09-24 15:06:03,812	DEBUG config.py:88 -- Setting up process group for: env:// [rank=1, world_size=2]
2024-09-24 15:06:03,812	DEBUG config.py:92 -- using gloo
2024-09-24 15:06:03,812	DEBUG config.py:92 -- using gloo
2024-09-24 15:06:03,863	INFO backend_executor.py:447 -- Started distributed worker processes: 
- (node_id=f4b1ea9c06ed3425b929fb70ede36ada34e3e3131b0c00318a7dee8a, ip=127.0.0.1, pid=31968) world_rank=0, local_rank=0, node_rank=0
- (node_id=f4b1ea9c06ed3425b929fb70ede36ada34e3e3131b0c00318a7dee8a, ip=127.0.0.1, pid=31969) world_rank=1, local_rank=1, node_rank=0
2024-09-24 15:06:03,893	DEBUG session.py:154 -- StorageContext on SESSION (rank=0):
StorageContext<
  storage_filesystem='local',
  storage_fs_path='/Users/hpguo/ray_results',
  experiment_dir_name='TorchTrainer_2024-09-24_15-06-00',
  trial_dir_name='TorchTrainer_2edb7_00000_0_2024-09-24_15-06-00',
  current_checkpoint_index=-1,
>
2024-09-24 15:06:03,893	DEBUG session.py:154 -- StorageContext on SESSION (rank=1):
StorageContext<
  storage_filesystem='local',
  storage_fs_path='/Users/hpguo/ray_results',
  experiment_dir_name='TorchTrainer_2024-09-24_15-06-00',
  trial_dir_name='TorchTrainer_2edb7_00000_0_2024-09-24_15-06-00',
  current_checkpoint_index=-1,
>
2024-09-24 15:06:03,893	DEBUG session.py:231 -- Changing the working directory to: /tmp/ray/session_2024-09-24_15-05-58_999739_31907/artifacts/2024-09-24_15-06-00/TorchTrainer_2024-09-24_15-06-00/working_dirs/TorchTrainer_2edb7_00000_0_2024-09-24_15-06-00
2024-09-24 15:06:03,893	DEBUG session.py:231 -- Changing the working directory to: /tmp/ray/session_2024-09-24_15-05-58_999739_31907/artifacts/2024-09-24_15-06-00/TorchTrainer_2024-09-24_15-06-00/working_dirs/TorchTrainer_2edb7_00000_0_2024-09-24_15-06-00
2024-09-24 15:06:04,906	DEBUG worker_group.py:216 -- Shutting down 2 workers.
2024-09-24 15:06:04,912	DEBUG worker_group.py:225 -- Graceful termination failed. Falling back to force kill.
2024-09-24 15:06:04,912	DEBUG worker_group.py:230 -- Shutdown successful.

Related issue number

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

justinvyu

This is nice! Here's a first pass with some questions.

python/ray/train/constants.py

python/ray/train/_internal/logging.py

justinvyu · 2024-10-17T01:28:24Z

python/ray/train/_internal/logging.yaml

+    (): ray._private.ray_logging.filters.CoreContextFilter
+
+handlers:
+  file:


Nit: file_text is more descriptive of the encoding mode

python/ray/train/_internal/logging.yaml

python/ray/train/_internal/logging.py

python/ray/__init__.py

omatthew98

Added some comments to pieces that I changed during the review for the ray data structured logging, overall lgtm please ping me when ready for a second pass.

python/ray/train/_internal/logging.py

omatthew98 · 2024-10-17T18:23:53Z

python/ray/train/_internal/logging.py

+    else:
+        config = _load_logging_config(DEFAULT_RAY_TRAIN_LOG_CONFIG_PATH)
+        if RAY_TRAIN_LOG_ENCODING == RAY_TRAIN_JSON_LOG_ENCODING_FORMAT:
+            for logger in config["loggers"].values():


For ray data I updated this to use a dictionary to replace the loggers (e.g. here and here).

python/ray/train/tests/test_logging.py

justinvyu

@omatthew98 @hongpeng-guo One other question I had: Why is the configuration via an environment variable rather than a config somewhere in the API? Is adding a config in the API (ex: DataContext / ray.train.RunConfig) a future plan?

omatthew98 · 2024-10-17T20:30:26Z

@omatthew98 @hongpeng-guo One other question I had: Why is the configuration via an environment variable rather than a config somewhere in the API? Is adding a config in the API (ex: DataContext / ray.train.RunConfig) a future plan?

That is a fair question, I was mostly going off what we already had in place which already used environment variables. I think there might be some argument to us wanting to use environment variables to ensure logging is configured as early as possible (e.g. on module initialization before A DataContext or train.RunConfig might exist), but not sure if that is the case.

omatthew98 · 2024-10-17T22:49:39Z

Just a heads up, based on this thread we are going to move our yaml configurations to python dictionary configurations.

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo · 2024-10-28T05:58:33Z

Comments handed, good to take a look for another round.

justinvyu · 2024-10-30T20:49:17Z

python/ray/train/constants.py

+DEFAULT_LOG_CONFIG_YAML_STRING = """
+version: 1
+disable_existing_loggers: False


Can we just have this be a dict similar to Data?

https://github.com/ray-project/ray/pull/48093/files#diff-3a2ffc1cbd2991bc0acf5093b76ff0fbe78e3c441c7c04cd8eb62c8ccf6dbbddR10

Yaml string may have syntax errors and is not native to python.

Good point! I was thinking yaml files have better readability comparing to json strings. However, after transformed as string, I don't think it's still that readable. I will make changes to update it to json string format.

justinvyu · 2024-10-30T20:50:28Z

python/ray/train/constants.py

+# Env. variable to specify the encoding of the file logs when using the default config.
+LOG_ENCODING_ENV = "RAY_TRAIN_LOG_ENCODING"
+
+# Env. variable to specify the logging config path use defaults if not set
+LOG_CONFIG_PATH_ENV = "RAY_TRAIN_LOG_CONFIG_PATH"
+


Can you move all these constants into the logging.py file? I'd rather keep this module isolated and have fewer changes in train/* code.

Why do we want to make this module isolated from the other parts?

I moved the default configuration json string and the default decoding format variables to the logging.py, but still kept the two env var name variables within constant.py. I think it makes more sense to keep all the user controlled env var names within constant.py.

justinvyu · 2024-10-30T21:04:06Z

python/ray/train/tests/test_logging.py

+import yaml
+
+import ray
+from ray.tests.conftest import *  # noqa


nit: don't think this is needed actually. conftest fixtures should automatically be visible

Good point! I can remove this unnecessary import.

justinvyu · 2024-10-30T21:08:20Z

python/ray/train/tests/test_logging.py

+    console_log_output = capsys.readouterr().err
+    for log_line in console_log_output.splitlines():
+        with pytest.raises(json.JSONDecodeError):
+            json.loads(log_line)


So all logger.warning(...) gets logged in JSON format to the stdout as well? Does it make more sense for console outputs to be in the normal text format, and then only the ray-train.log contains the JSON format?

Also, is it printed to stderr or stdout?

for logger.warning(...), it is logged in JSON format to ray-train.log file, and logged to console as normal text format. The code here will raise pytest.raises(json.JSONDecodeError) because it is normal text, not json in the console output format.

By default, all the console output in python logger goes to stderr. Reference: https://docs.python.org/3/howto/logging.html#advanced-logging-tutorial. and https://github.com/hongpeng-guo/ray/blob/6a5fc2d39b0265e7b578f069a84ae772c123801b/python/ray/_private/log.py#L30

alanwguo · 2024-10-30T21:27:44Z

Can we include local, world, and node rank as part of the structure?

hongpeng-guo · 2024-10-31T00:54:57Z

Can we include local, world, and node rank as part of the structure?

Sure, I am thinking about adding more train only context in a followup PR. We also need to differentiate between driver, controller, and worker processes. All the ranks related concepts are only defined on worker processes.

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo · 2024-11-01T21:48:19Z

Update: I added a TrainContextFilter that will append rank information (world_rank, local_rank, world_size, local_world_size, and node_rank) to the structured logging records if this piece of log is emitted from a train worker.
cc @alanwguo

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo added 5 commits September 19, 2024 22:28

copy over ray data structure log

48c0961

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

remove TRACE level for ray train

90b6893

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

move constant variables to the constant.py file

dc79a60

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

fix default yaml config path

d388da5

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

fix unittests

ace76a7

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo requested review from justinvyu, matthewdeng, raulchen and woshiyyya as code owners September 24, 2024 06:50

hongpeng-guo added 3 commits September 23, 2024 23:51

Merge branch 'master' into hpguo/train_structured_log

d6b64c0

add unittest to BUILD file

ddadc1c

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

modify setup.py to include yaml file into the python package

6216d4f

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo requested review from richardliaw, ericl and edoakes as code owners September 24, 2024 19:56

hongpeng-guo changed the title ~~[Train Log][WIP] Ray Train Structured Logging~~ [Train Log]Ray Train Structured Logging Sep 24, 2024

hongpeng-guo added 4 commits September 27, 2024 13:42

update log

c77a181

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

update logging

427b861

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

Merge branch 'master' into hpguo/train_structured_log

58bbf5d

use () key instead if class for filter

e4d8b63

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo requested review from alanwguo, kevin85421, GeneDer and omatthew98 October 10, 2024 00:35

justinvyu reviewed Oct 17, 2024

View reviewed changes

omatthew98 reviewed Oct 17, 2024

View reviewed changes

justinvyu reviewed Oct 17, 2024

View reviewed changes

handle comments

99266ae

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo requested a review from aslonnie as a code owner October 28, 2024 00:46

hongpeng-guo added 7 commits October 27, 2024 17:53

add test json logging configuration

cbf4677

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

handle comments

d3aeff8

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

resolve merge conflict

02d439f

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

remove reduant __init__ part

c3adf12

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

add back the change on __init__.py

0fed499

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

change yaml file to constant yaml string

35249c8

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

clean code chanegs

6a5fc2d

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

aslonnie removed their request for review October 28, 2024 17:26

justinvyu reviewed Oct 30, 2024

View reviewed changes

hongpeng-guo added 2 commits October 30, 2024 21:57

handle comments

1768dc6

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

handle comments

c1a9955

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

hongpeng-guo added 3 commits November 1, 2024 14:50

add TrainContextFilter that add ranks information to worker nodes

82b23ad

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

Merge remote-tracking branch 'origin' into hpguo/train_structured_log

d79119f

fix corner cases

b6c8cbd

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Train Log]Ray Train Structured Logging #47806

[Train Log]Ray Train Structured Logging #47806

hongpeng-guo commented Sep 24, 2024 •

edited

Loading

justinvyu left a comment

justinvyu Oct 17, 2024

omatthew98 left a comment

omatthew98 Oct 17, 2024

justinvyu left a comment

omatthew98 commented Oct 17, 2024

omatthew98 commented Oct 17, 2024

hongpeng-guo commented Oct 28, 2024

justinvyu Oct 30, 2024

hongpeng-guo Oct 30, 2024

justinvyu Oct 30, 2024

hongpeng-guo Oct 30, 2024

hongpeng-guo Oct 31, 2024

justinvyu Oct 30, 2024

hongpeng-guo Oct 30, 2024

justinvyu Oct 30, 2024

hongpeng-guo Oct 31, 2024

alanwguo commented Oct 30, 2024

hongpeng-guo commented Oct 31, 2024 •

edited

Loading

hongpeng-guo commented Nov 1, 2024 •

edited

Loading

[Train Log]Ray Train Structured Logging #47806

Are you sure you want to change the base?

[Train Log]Ray Train Structured Logging #47806

Conversation

hongpeng-guo commented Sep 24, 2024 • edited Loading

Why are these changes needed?

Example

JSON Logging

Text Logging

Related issue number

Checks

justinvyu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

omatthew98 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinvyu left a comment

Choose a reason for hiding this comment

omatthew98 commented Oct 17, 2024

omatthew98 commented Oct 17, 2024

hongpeng-guo commented Oct 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alanwguo commented Oct 30, 2024

hongpeng-guo commented Oct 31, 2024 • edited Loading

hongpeng-guo commented Nov 1, 2024 • edited Loading

hongpeng-guo commented Sep 24, 2024 •

edited

Loading

hongpeng-guo commented Oct 31, 2024 •

edited

Loading

hongpeng-guo commented Nov 1, 2024 •

edited

Loading