[release] stream the full anyscale log to buildkite #47808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslonnie
reviewed
Sep 24, 2024
There was a problem hiding this comment.
this will print way too many lines for some of the release tests. there are some release tests that have logs that are very verbose.
if we need this, this needs to be an option in the release test definition. or maybe controllable with an env var where default is still 100.
|
yes, let's control this through a flag |
can-anyscale
force-pushed
the
can-rel02
branch
5 times, most recently
from
5cd2f46
to
2c596b4
Compare
aslonnie
approved these changes
Sep 24, 2024
Comment on lines
+117
to
+118
| "--log-streaming-limit", | ||
| "100", |
There was a problem hiding this comment.
we have the default flag value, so we can just skip it here?
aslonnie
reviewed
Sep 24, 2024
| @@ -390,6 +392,7 @@ def run_release_test( | |||
| cluster_env_id: Optional[str] = None, | |||
| no_terminate: bool = False, | |||
| test_definition_root: Optional[str] = None, | |||
| log_streaming_limit: int = LAST_LOGS_LENGTH, | |||
There was a problem hiding this comment.
unit test for this new feature?
There was a problem hiding this comment.
added tests that the value passed into this function overrides the default value and go all the way to the cluster manager
can-anyscale
force-pushed
the
can-rel02
branch
from
2c596b4
to
a8acc0f
Compare
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-rel02
branch
from
a8acc0f
to
e489cb1
Compare
khluu
approved these changes
Sep 24, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only print 100 last lines of anyscale job log to buildkite. This PR removes that limit and prints everything instead. CC: @kouroshHakha
Test: