Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix a Typo in dict_to_state function parameter name #47822

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

MengjinYan
Copy link
Collaborator

@MengjinYan MengjinYan commented Sep 26, 2024

Why are these changes needed?

The PR fix a typo in the dict_to_state function parameter to make it consistent with the type.

The comment was made in #47818.

Related issue number

#44541

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Sep 26, 2024
python/ray/util/state/common.py Show resolved Hide resolved
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
@jjyao jjyao enabled auto-merge (squash) September 26, 2024 16:47
@jjyao jjyao merged commit a157bd8 into master Sep 26, 2024
6 checks passed
@jjyao jjyao deleted the issue-44541-1 branch September 26, 2024 17:53
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ct#47822)

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants