[core] Introducing InstrumentedIOContextWithThread. #47831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit cf3f343 Author: Ruiyang Wang <rywang014@gmail.com> Date: Wed Sep 25 14:33:23 2024 -0700 update doc Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit a1ab6c6 Author: Ruiyang Wang <rywang014@gmail.com> Date: Wed Sep 25 14:19:59 2024 -0700 fix atomics in periodical_runner Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit 99f7ba9 Author: Ruiyang Wang <rywang014@gmail.com> Date: Wed Sep 25 10:23:26 2024 -0700 size_t -> int for proto Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit bbf02cd Author: Ruiyang Wang <rywang014@gmail.com> Date: Tue Sep 24 16:06:50 2024 -0700 fix Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit 7cd7705 Author: Ruiyang Wang <rywang014@gmail.com> Date: Tue Sep 24 12:17:50 2024 -0700 atomics Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit a87c39d Author: Ruiyang Wang <rywang014@gmail.com> Date: Tue Sep 24 11:40:12 2024 -0700 fix atomics now that we have multiple thread reads... Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit 36fc808 Author: Ruiyang Wang <rywang014@gmail.com> Date: Mon Sep 23 16:31:17 2024 -0700 fix cpp test Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit 5d8eaee Merge: a021521 8173a1e Author: Ruiyang Wang <56065503+rynewang@users.noreply.github.com> Date: Fri Sep 20 15:47:51 2024 -0700 Merge branch 'master' into dedicated-kv-ioctx commit a021521 Merge: c84fd80 ab94e48 Author: Ruiyang Wang <56065503+rynewang@users.noreply.github.com> Date: Thu Sep 19 17:19:54 2024 -0700 Merge branch 'master' into dedicated-kv-ioctx commit c84fd80 Author: Ruiyang Wang <rywang014@gmail.com> Date: Wed Sep 18 14:30:59 2024 -0700 move gcs_table_storage_ back to main service. Signed-off-by: Ruiyang Wang <rywang014@gmail.com> commit bcf81c8 Author: Ruiyang Wang <rywang014@gmail.com> Date: Wed Sep 18 13:53:21 2024 -0700 dedicated kv ioctx Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
jjyao
reviewed
Sep 26, 2024
jjyao
approved these changes
Sep 26, 2024
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had several ad-hoc places to do a "thread and io_context" pattern: create a thread dedicated to an asio io_context, then workload can post async tasks onto it. This makes duplicate code: everywhere we create threads, implement stop and join.
Introducing InstrumentedIOContextWithThread that does exactly this and replaces existing usages.
Also fixes some absl::Time computations with best practice.
This is refactoring. Should have no runtime difference.