Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gRPC] Fixing gRPC Server Call to be instantiated immediately for unbounded handlers #47836

Closed
wants to merge 4 commits into from
Closed

[gRPC] Fixing gRPC Server Call to be instantiated immediately for unbounded handlers #47836

wants to merge 4 commits into from

Conversation

alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Sep 27, 2024 •
edited
Loading

Why are these changes needed?

NOTE: Stacked onto #47664

This change makes sure that for unbounded RPCs (like KV-handlers, etc) we're re-creating ServerCall inside CQ polling thread instead of HandleRequestImpl invoked on main event-loop (potentially having unpredictable delays)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alexeykudinkin alexeykudinkin added the go add ONLY when ready to merge, run all tests label Sep 27, 2024
@alexeykudinkin
Make sure new ServerCall is created inside CQ polling thread and no…
7d3c707 
…t the main event-loop to guarantee

that handlers for which back-pressure is disabled always have outstanding `ServerCall`s

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Tidying up
24352ed 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
lint
c78a29c 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Tidying up
aed8a43 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@jjyao jjyao deleted the branch ray-project:ak/grpc-srv-hndlr-fix October 1, 2024 02:36
@jjyao jjyao closed this Oct 1, 2024
@alexeykudinkin alexeykudinkin mentioned this pull request Oct 17, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao Awaiting requested review from jjyao

Assignees

@jjyao jjyao

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeykudinkin @jjyao