Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Change many Ray ID logs to WithField. #47844

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

rynewang
Copy link
Contributor

@rynewang rynewang commented Sep 27, 2024

Use structured logging by changing more << node_id to use .WithField(node_id). This is not intended to be a complete work, but it should cover most of the cases. We did the work for NodeID, WorkerID, ActorID, JobID, TaskID, PlacementGroupID.

Some logs have multiple node_ids, for example:

  RAY_LOG(DEBUG).WithField(object_id)
      << "ReceiveObjectChunk on " << self_node_id_ << " from " << node_id
      << " of object, chunk index: " << chunk_index
      << ", chunk data size: " << data.size() << ", object size: " << data_size;

To avoid confusion, for these we only use WithField(object_id) don't use WithField on either of the Node IDs.

This PR should have no change on Ray other than logs.

Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
@rynewang rynewang requested a review from a team as a code owner September 27, 2024 19:09
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
@rynewang rynewang enabled auto-merge (squash) September 28, 2024 01:03
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 28, 2024
@rynewang rynewang merged commit 44bdd4d into ray-project:master Sep 28, 2024
7 checks passed
@rynewang rynewang deleted the with-fields branch September 28, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants