Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAG] Refactor nccl to communicator channel. #47845

Closed
wants to merge 24 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,11 @@ def render_svg_logo(path):

html_sidebars = {
"**": [
"main-sidebar-readthedocs"
if os.getenv("READTHEDOCS") == "True"
else "main-sidebar"
(
"main-sidebar-readthedocs"
if os.getenv("READTHEDOCS") == "True"
else "main-sidebar"
)
],
"ray-overview/examples": [],
}
Expand Down
6 changes: 3 additions & 3 deletions python/ray/_private/accelerators/npu.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ def set_current_process_visible_accelerator_ids(
if os.environ.get(NOSET_ASCEND_RT_VISIBLE_DEVICES_ENV_VAR):
return

os.environ[
NPUAcceleratorManager.get_visible_accelerator_ids_env_var()
] = ",".join([str(i) for i in visible_npu_devices])
os.environ[NPUAcceleratorManager.get_visible_accelerator_ids_env_var()] = (
",".join([str(i) for i in visible_npu_devices])
)
14 changes: 8 additions & 6 deletions python/ray/_private/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,9 @@ def resources_from_ray_options(options_dict: Dict[str, Any]) -> Dict[str, Any]:
if object_store_memory is not None:
resources["object_store_memory"] = object_store_memory
if accelerator_type is not None:
resources[
f"{ray_constants.RESOURCE_CONSTRAINT_PREFIX}{accelerator_type}"
] = 0.001
resources[f"{ray_constants.RESOURCE_CONSTRAINT_PREFIX}{accelerator_type}"] = (
0.001
)

return resources

Expand Down Expand Up @@ -1146,9 +1146,11 @@ def new_func(*args, **kwargs):
+ (
f"in version {removal_release}."
if removal_release is not None
else f"after {removal_date}"
if removal_date is not None
else "in a future version"
else (
f"after {removal_date}"
if removal_date is not None
else "in a future version"
)
)
+ (f" {instructions}" if instructions is not None else "")
)
Expand Down
Loading