Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray Core] Fix the Paths in the Generated Monitoring Configs to Consider temp-dir #47871

Merged
merged 8 commits into from
Oct 15, 2024
Merged

[Ray Core] Fix the Paths in the Generated Monitoring Configs to Consider temp-dir #47871

merged 8 commits into from
Oct 15, 2024

Commits on Sep 28, 2024

  1. Fix the path in the default grafana/prometheus config to consider the… 

    … temp-dir

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
    @MengjinYan
    MengjinYan committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    943df20 View commit details
    Browse the repository at this point in the history

  2. Remove the merged files 

    Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
    @MengjinYan
    MengjinYan committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d1381b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. fix lint issue 

    Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
    @MengjinYan
    MengjinYan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8681c8c View commit details
    Browse the repository at this point in the history

  2. 1. fix lint 

    2. fix comment
3. Update the logic in the install_and_start_prometheus to continue leverage the hard coded file, in order to avoid generating a file in user's package or working directory. Tests added accordingly

Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
    @MengjinYan
    MengjinYan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3730c8e View commit details
    Browse the repository at this point in the history

  3. update comment in metrics_head.py 

    Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
    @MengjinYan
    MengjinYan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4d2f6d6 View commit details
    Browse the repository at this point in the history

  4. fix linter error 

    Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
    @MengjinYan
    MengjinYan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    84c7ae4 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Fix comment 

    Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
    @MengjinYan
    MengjinYan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    49e8487 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'master' into issue-41648

    @MengjinYan
    MengjinYan authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3bd284d View commit details
    Browse the repository at this point in the history