Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsHeadNode tag to node metrics #47872

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Add IsHeadNode tag to node metrics #47872

merged 6 commits into from
Oct 25, 2024

Conversation

vigneshka
Copy link
Contributor

@vigneshka vigneshka commented Sep 30, 2024 •
edited
Loading

Why are these changes needed?

Adding IsHeadNode tag to node metrics

Screenshot 2024-10-24 at 6 36 57 PM Screenshot 2024-10-24 at 6 36 47 PM Screenshot 2024-10-24 at 6 37 28 PM Screenshot 2024-10-24 at 6 38 08 PM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@vigneshka
Add IsHeadNode tag to node metrics
a7bd86b 
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
vigneshka and others added 2 commits October 24, 2024 12:05
@vigneshka
Merge branch 'master' into vigneshka/head-node-tag
ed31505
@vigneshka
fix
0f9efb0 
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
@vigneshka
Merge branch 'master' into vigneshka/head-node-tag
0dfa402 
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
@vigneshka vigneshka marked this pull request as ready for review October 25, 2024 00:10
vigneshka and others added 2 commits October 24, 2024 17:32
@vigneshka
change dashboards
cf2516e 
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
@vigneshka
Merge branch 'master' into vigneshka/head-node-tag
f18b6fa 
Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
pcmoritz
pcmoritz approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but what I currently don't understand is why are there two head nodes with different IP addresses in the graphs?

@vigneshka
Copy link
Contributor Author

@pcmoritz , I think I took the screenshot between some cluster restarts.

Just ran a quick job with a 2 worker cluster, and shows 1 head as expected:
image

@pcmoritz pcmoritz enabled auto-merge (squash) October 25, 2024 02:13
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 25, 2024
@pcmoritz pcmoritz merged commit dbcf4cc into ray-project:master Oct 25, 2024
7 checks passed
@alanwguo alanwguo mentioned this pull request Oct 31, 2024
Closed
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@vigneshka @Jay-ju
Add IsHeadNode tag to node metrics (ray-project#47872)
ee5ef39 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

Adding IsHeadNode tag to node metrics

<img width="1823" alt="Screenshot 2024-10-24 at 6 36 57 PM"
src="https://github.com/user-attachments/assets/855919db-b08e-4966-ae50-79c6de78bd90">
<img width="1818" alt="Screenshot 2024-10-24 at 6 36 47 PM"
src="https://github.com/user-attachments/assets/cb323682-d1c5-451a-98b2-eb99aff938a1">
<img width="1818" alt="Screenshot 2024-10-24 at 6 37 28 PM"
src="https://github.com/user-attachments/assets/f783cd67-e7da-4230-9f02-fa2d625a17e3">
<img width="1824" alt="Screenshot 2024-10-24 at 6 38 08 PM"
src="https://github.com/user-attachments/assets/08998ab1-7702-4fb3-8dea-76e5c8ab5232">


## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [x] Release tests
   - [x] This PR is not tested :(

---------

Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@vigneshka @JP-sDEV
Add IsHeadNode tag to node metrics (ray-project#47872)
0075558 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

Adding IsHeadNode tag to node metrics

<img width="1823" alt="Screenshot 2024-10-24 at 6 36 57 PM"
src="https://github.com/user-attachments/assets/855919db-b08e-4966-ae50-79c6de78bd90">
<img width="1818" alt="Screenshot 2024-10-24 at 6 36 47 PM"
src="https://github.com/user-attachments/assets/cb323682-d1c5-451a-98b2-eb99aff938a1">
<img width="1818" alt="Screenshot 2024-10-24 at 6 37 28 PM"
src="https://github.com/user-attachments/assets/f783cd67-e7da-4230-9f02-fa2d625a17e3">
<img width="1824" alt="Screenshot 2024-10-24 at 6 38 08 PM"
src="https://github.com/user-attachments/assets/08998ab1-7702-4fb3-8dea-76e5c8ab5232">


## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [x] Release tests
   - [x] This PR is not tested :(

---------

Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@vigneshka @mohitjain2504
Add IsHeadNode tag to node metrics (ray-project#47872)
c796026 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

Adding IsHeadNode tag to node metrics

<img width="1823" alt="Screenshot 2024-10-24 at 6 36 57 PM"
src="https://github.com/user-attachments/assets/855919db-b08e-4966-ae50-79c6de78bd90">
<img width="1818" alt="Screenshot 2024-10-24 at 6 36 47 PM"
src="https://github.com/user-attachments/assets/cb323682-d1c5-451a-98b2-eb99aff938a1">
<img width="1818" alt="Screenshot 2024-10-24 at 6 37 28 PM"
src="https://github.com/user-attachments/assets/f783cd67-e7da-4230-9f02-fa2d625a17e3">
<img width="1824" alt="Screenshot 2024-10-24 at 6 38 08 PM"
src="https://github.com/user-attachments/assets/08998ab1-7702-4fb3-8dea-76e5c8ab5232">

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [x] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [x] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [x] Release tests
   - [x] This PR is not tested :(

---------

Signed-off-by: Vignesh Hirudayakanth <vignesh@anyscale.com>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vigneshka @pcmoritz