Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only DreamerV3 on new API stack remains with tf now). #47892

Merged
merged 10 commits into from
Oct 7, 2024
Merged

[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only DreamerV3 on new API stack remains with tf now). #47892

merged 10 commits into from
Oct 7, 2024
+105 −961

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 3, 2024 •
edited
Loading

Remove Tf support on new API stack for PPO/IMPALA/APPO (only DreamerV3 on new API stack remains with tf for now).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
87bd349 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
LINT
8801948 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) October 4, 2024 23:13
@github-actions github-actions bot disabled auto-merge October 4, 2024 23:14
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 4, 2024
@sven1977 sven1977 changed the title [RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only DreamerV3 on new API stack remains with tf for now). [RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only DreamerV3 on new API stack remains with tf now). Oct 4, 2024
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into remo…
286930e 
…ve_tf_on_new_stack_for_ppo_impala_appo
@sven1977
wip
213450c 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge remote-tracking branch 'origin/remove_tf_on_new_stack_for_ppo_i…
ccc3177 
…mpala_appo' into remove_tf_on_new_stack_for_ppo_impala_appo
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into remo…
0193299 
…ve_tf_on_new_stack_for_ppo_impala_appo

Signed-off-by: sven1977 <svenmika1977@gmail.com>

# Conflicts:
#	rllib/algorithms/ppo/tests/test_ppo_rl_module.py
#	rllib/algorithms/ppo/tf/ppo_tf_rl_module.py
@sven1977
wip
b00a21b 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 6, 2024
simonsays1980
simonsays1980 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we also deprecate all corresponding tests in BUILD?

rllib/algorithms/appo/appo.py
from ray.rllib.algorithms.appo.tf.appo_tf_learner import APPOTfLearner

return APPOTfLearner
elif self.framework_str in ["tf2", "tf"]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the Torch star rising :)

@sven1977 sven1977 merged commit 04ea05a into ray-project:master Oct 7, 2024
5 checks passed
@sven1977 sven1977 deleted the remove_tf_on_new_stack_for_ppo_impala_appo branch October 7, 2024 12:35
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
960e28d 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
251ec0a 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
03e35d0 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
493d0f7 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
628ac0d 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
0d499f5 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
588d44b 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
759b0c8 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Remove Tf support on new API stack for PPO/IMPALA/APPO (only …
bbb59bb 
…DreamerV3 on new API stack remains with tf now). (ray-project#47892)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980