[Train] Remove deprecated mosaic and sklearn trainer code #47901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Superskyyy <yihaochen@apache.org>
Signed-off-by: Superskyyy <yihaochen@apache.org>
Signed-off-by: Superskyyy <yihaochen@apache.org>
|
I'm not sure about the mosaic util - RayLogger, is it still potentially required by TorchTrainer in any case? |
Superskyyy
changed the title
Superskyyy
requested review from
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen and
woshiyyya
as code owners
Signed-off-by: Superskyyy <yihaochen@apache.org>
matthewdeng
reviewed
Oct 4, 2024
python/ray/train/mosaic/__init__.py
Outdated
There was a problem hiding this comment.
We can go ahead and remove this entirely, the RayLogger was only used as part of the MosaicTrainer before.
There was a problem hiding this comment.
Could you also do a quick scan to remove anything that might reference these? e.g. I saw there is a python/ray/train/examples/mosaic_cifar10_example.py that references the MosaicTrainer.
There was a problem hiding this comment.
Sure, I will do that
|
@Superskyyy is this ready for re-review? |
matthewdeng
approved these changes
Oct 8, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…t#47901) **Both trainers are now hard-deprecated.** This PR removes the code paths that confuses Ray train users on Mosaic and Sklearn. This should have been done a while ago. Signed-off-by: Superskyyy <yihaochen@apache.org> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42257
#42814
Why are these changes needed?
Both trainers are now hard-deprecated. This PR removes the code paths that confuses Ray train users on Mosaic and Sklearn. This should have been done a while ago.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.