[Data] Allow specifying insertion index when registering custom plan optimization Rules
#48039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
scottjlee
changed the title
RulesRules
scottjlee
requested review from
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
bveeramani
approved these changes
Oct 16, 2024
bveeramani
reviewed
Oct 16, 2024
| def register_logical_rule(cls: Type[Rule]): | ||
| _LOGICAL_RULES.append(cls) | ||
| def register_logical_rule(cls: Type[Rule], insert_index: Optional[int] = None): | ||
| if not insert_index: |
There was a problem hiding this comment.
Should this be if insert_index is not None? If insert_index == 0, this'd append the rule rather than making it the first item, right?
8 tasks
scottjlee
added a commit
that referenced
this pull request
Oct 16, 2024
…8051) ## Why are these changes needed? Fix the bug reported #48039 (comment) ## Related issue number ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: Scott Lee <sjl@anyscale.com>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…optimization `Rule`s (ray-project#48039) ## Why are these changes needed? Currently, when registering custom `LogicalPlan` or `PhysicalPlan` optimization `Rule`s, the only option is to append to the end of the registered rules. The optimization rules will then be executed in order. This is limiting because there are some cases where we want to specify the order of newly registered rules. For example, we may want to add our own custom rule prior to operator fusion taking place. This PR adds the ability to specify an insertion index when registering a custom logical/physical rule. The existing behavior of methods are unchanged. ## Related issue number ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Scott Lee <sjl@anyscale.com>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…y-project#48051) ## Why are these changes needed? Fix the bug reported ray-project#48039 (comment) ## Related issue number ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: Scott Lee <sjl@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, when registering custom
LogicalPlanorPhysicalPlanoptimizationRules, the only option is to append to the end of the registered rules. The optimization rules will then be executed in order. This is limiting because there are some cases where we want to specify the order of newly registered rules. For example, we may want to add our own custom rule prior to operator fusion taking place.This PR adds the ability to specify an insertion index when registering a custom logical/physical rule. The existing behavior of methods are unchanged.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.