[Core] Add PENDING_ACTOR_TASK_ARGS_FETCH and PENDING_ACTOR_TASK_ORDERING_OR_CONCURRENCY TaskStatus #48242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CONCURRENCY TaskStatus Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
|
FYI: @alexeykudinkin |
MengjinYan
reviewed
Oct 25, 2024
MengjinYan
approved these changes
Oct 28, 2024
Comment on lines
+830
to
+834
| // The actor task is fetching arguments. This happens after the actor worker | ||
| // receives the task and the actor task has object refs as arguments. | ||
| PENDING_ACTOR_TASK_ARGS_FETCH = 6; | ||
| // The actor task is waiting due to ordering or concurrency constraints. | ||
| PENDING_ACTOR_TASK_ORDERING_OR_CONCURRENCY = 7; |
There was a problem hiding this comment.
Wait, why are these specific to actor tasks @jjyao?
There was a problem hiding this comment.
For normal task, args fetch is before SUBMITTED_TO_WORKER and happens in raylet and is PENDING_ARGS_FETCH. Also normal task, you don't need to wait for concurrency, each a worker process only runs one normal task at a time.
There was a problem hiding this comment.
Understood. It's a bit odd to encode the entity name into the state, but i see your point there.
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…ING_OR_CONCURRENCY TaskStatus (ray-project#48242) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…ING_OR_CONCURRENCY TaskStatus (ray-project#48242) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…ING_OR_CONCURRENCY TaskStatus (ray-project#48242) Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently we don't know which status an actor task has in between
SUBMITTED_TO_WORKERANDRUNNING.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.