Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Quick fix for RLlib's index.html page (environment tab broken). #48442

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[RLlib] Quick fix for RLlib's index.html page (environment tab broken). #48442

merged 1 commit into from
Oct 30, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 30, 2024 •
edited
Loading

Quick fix for RLlib's index.html page (environment tab broken).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
79f10d5 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 assigned sven1977 and simonsays1980 and unassigned sven1977 Oct 30, 2024
@sven1977 sven1977 added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. rllib RLlib related issues docs An issue or change related to documentation rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack labels Oct 30, 2024
simonsays1980
simonsays1980 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean and shine.

@sven1977 sven1977 enabled auto-merge (squash) October 30, 2024 14:47
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 30, 2024
@sven1977 sven1977 merged commit 5984023 into ray-project:master Oct 30, 2024
6 checks passed
@sven1977 sven1977 deleted the fix_rllib_index_page branch October 31, 2024 13:01
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@sven1977 @Jay-ju
[RLlib] Quick fix for RLlib's index.html page (environment tab broken…
574d0db 
…). (ray-project#48442)
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@sven1977 @JP-sDEV
[RLlib] Quick fix for RLlib's index.html page (environment tab broken…
27e6b14 
…). (ray-project#48442)

Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@sven1977 @mohitjain2504
[RLlib] Quick fix for RLlib's index.html page (environment tab broken…
88c09f0 
…). (ray-project#48442)

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
docs An issue or change related to documentation go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980