Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Upgrade Arrow version from 17 to 18 #48448

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

scottjlee
Copy link
Contributor

@scottjlee scottjlee commented Oct 30, 2024

Why are these changes needed?

Upgrade CI to use pyarrow 18, the latest released version from Pyarrow.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Scott Lee added 4 commits October 29, 2024 16:34
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
@scottjlee scottjlee requested a review from a team as a code owner October 30, 2024 18:23
@scottjlee scottjlee added the go add ONLY when ready to merge, run all tests label Oct 30, 2024
@@ -10,6 +10,6 @@ srcs:
- python/requirements/ml/data-requirements.txt
- python/requirements/ml/data-test-requirements.txt
build_args:
- ARROW_VERSION=17.*
- ARROW_VERSION=18.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to change the versions in maybe data-requirements.txt or something so that the python/requirements_compiled is updated too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we don't want to force users to install pyarrow 18 / the latest version of pyarrow. they should be able to choose any version within the general bounds (pyarrow >= 6.0.1,<18). so i think we shouldn't add any explicit pyarrow pin in data-requirements.txt or data-test-requirements.txt? cc @can-anyscale

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python/requirements_compiled.txt indicates the versions we install in the rayproject/ray docker image (orthogonal to ray pypi). It's currently on 14 (https://github.com/ray-project/ray/blob/master/python/requirements_compiled.txt#L1595) so pretty outdated itself.

It's optional but I recommend to update it to the latest version yes (or whoever supports python 3.13 will eventually upgrade it anyway). If so, maybe do it in another PR; it's not a blocker in this PR.

@richardliaw
Copy link
Contributor

Hi @can-anyscale @aslonnie can we get this merged?

Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@can-anyscale can-anyscale enabled auto-merge (squash) December 3, 2024 18:51
@can-anyscale
Copy link
Collaborator

upgraded to latest and enable auto-merge ;)

PhilippWillms pushed a commit to PhilippWillms/ray that referenced this pull request Dec 3, 2024
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow.

Signed-off-by: Scott Lee <sjl@anyscale.com>
Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
jecsand838 pushed a commit to jecsand838/ray that referenced this pull request Dec 4, 2024
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow.

Signed-off-by: Scott Lee <sjl@anyscale.com>
Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
@can-anyscale can-anyscale merged commit f498afc into ray-project:master Dec 4, 2024
6 checks passed
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow.

Signed-off-by: Scott Lee <sjl@anyscale.com>
Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow.

Signed-off-by: Scott Lee <sjl@anyscale.com>
Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow.

Signed-off-by: Scott Lee <sjl@anyscale.com>
Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants