-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Upgrade Arrow version from 17 to 18 #48448
[Data] Upgrade Arrow version from 17 to 18 #48448
Conversation
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
@@ -10,6 +10,6 @@ srcs: | |||
- python/requirements/ml/data-requirements.txt | |||
- python/requirements/ml/data-test-requirements.txt | |||
build_args: | |||
- ARROW_VERSION=17.* | |||
- ARROW_VERSION=18.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to change the versions in maybe data-requirements.txt
or something so that the python/requirements_compiled
is updated too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, we don't want to force users to install pyarrow 18 / the latest version of pyarrow. they should be able to choose any version within the general bounds (pyarrow >= 6.0.1,<18
). so i think we shouldn't add any explicit pyarrow pin in data-requirements.txt
or data-test-requirements.txt
? cc @can-anyscale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python/requirements_compiled.txt
indicates the versions we install in the rayproject/ray docker image (orthogonal to ray pypi). It's currently on 14 (https://github.com/ray-project/ray/blob/master/python/requirements_compiled.txt#L1595) so pretty outdated itself.
It's optional but I recommend to update it to the latest version yes (or whoever supports python 3.13 will eventually upgrade it anyway). If so, maybe do it in another PR; it's not a blocker in this PR.
Hi @can-anyscale @aslonnie can we get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgraded to latest and enable auto-merge ;) |
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow. Signed-off-by: Scott Lee <sjl@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow. Signed-off-by: Scott Lee <sjl@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: Connor Sanders <connor@elastiflow.com>
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow. Signed-off-by: Scott Lee <sjl@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: hjiang <dentinyhao@gmail.com>
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow. Signed-off-by: Scott Lee <sjl@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow. Signed-off-by: Scott Lee <sjl@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Why are these changes needed?
Upgrade CI to use pyarrow 18, the latest released version from Pyarrow.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.