fix token expiration for ray autoscaler #48481
Open
+39
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
wadhah101
force-pushed
the
fix-token-expiration
branch
5 times, most recently
from
a295db4 to
8567c0f
Compare
wadhah101
commented
Nov 1, 2024
wadhah101
force-pushed
the
fix-token-expiration
branch
2 times, most recently
from
e1fc6c2 to
5d1f28c
Compare
|
all tests are passing, PR up to date @hongchaodeng @kevin85421 @MortalHappiness |
wadhah101
force-pushed
the
fix-token-expiration
branch
from
5d1f28c to
4101b68
Compare
|
I will review next week. |
|
Hey @kevin85421 any update on this one? |
|
@wadhah101 thank you for the PR! Would you mind rebasing with the master branch? |
wadhah101
force-pushed
the
fix-token-expiration
branch
2 times, most recently
from
e0b42fa to
ff6d1be
Compare
|
@kevin85421 rebased |
|
CI fails. Let me retry it. |
|
CI failed again. I synced the branch with the master branch. If it still fails, maybe you need to take a look at the failure. |
|
It still failed. Would you mind fixing the issue? |
Signed-off-by: wa101 <wadhah.mahroug15@gmail.com>
Signed-off-by: wa101 <wadhah.mahroug15@gmail.com>
wadhah101
force-pushed
the
fix-token-expiration
branch
from
bca47af to
f41cae2
Compare
|
@kevin85421 |
|
@wadhah101, the CR is still failing. Would you mind taking a look? |
Signed-off-by: wa101 <wadhah.mahroug15@gmail.com>
wadhah101
force-pushed
the
fix-token-expiration
branch
from
f850ae5 to
37b7df0
Compare
|
@wadhah101 CI is still failing |
28 tasks
|
@jjyao I will try to fix the test, thanks 😄 |
|
Thanks. Ping us if you need any helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
On AKS 1.30 Ray autoscaler fails after an hour of activity due to AKS new token policy. Check issue for more details
Related issue number
closes ray-project/kuberay#2324
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.