Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test test_ray_debugger failure on macOS #48527

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix test test_ray_debugger failure on macOS #48527

merged 1 commit into from
Nov 4, 2024

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Nov 3, 2024

Why are these changes needed?

Fixes a race condition on macOS

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Nov 3, 2024

fixes #48524

@pcmoritz pcmoritz added the go add ONLY when ready to merge, run all tests label Nov 3, 2024
@pcmoritz
Copy link
Contributor Author

pcmoritz commented Nov 4, 2024

@can-anyscale Can you merge this to fix the test failure on macOS? :)

@pcmoritz pcmoritz enabled auto-merge (squash) November 4, 2024 06:13
@can-anyscale can-anyscale disabled auto-merge November 4, 2024 17:27
@can-anyscale can-anyscale merged commit c1b2282 into master Nov 4, 2024
6 checks passed
@can-anyscale can-anyscale deleted the fix-macos-debugging-test branch November 4, 2024 17:28
@can-anyscale
Copy link
Collaborator

merged thankks ;)

Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@pcmoritz @Jay-ju
Fix test test_ray_debugger failure on macOS (ray-project#48527)
fb5f28b 
Fixes a race condition on macOS
aslonnie added a commit that referenced this pull request Nov 5, 2024
@aslonnie
cherrypick #48563 and #48527
3faf6fd 
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie added a commit that referenced this pull request Nov 5, 2024
@aslonnie
cherrypick #48563 and #48527 (#48574)
5a6c335 
fixes rllib release tests and mac debugger test

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@pcmoritz @JP-sDEV
Fix test test_ray_debugger failure on macOS (ray-project#48527)
bcba786 
Fixes a race condition on macOS
Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@pcmoritz @mohitjain2504
Fix test test_ray_debugger failure on macOS (ray-project#48527)
e838fe0 
Fixes a race condition on macOS

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcmoritz @can-anyscale