Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix Ascend NPU discovery to support 8+ cards per node #48543

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[Core] Fix Ascend NPU discovery to support 8+ cards per node #48543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f66994
Update npu.py
liuxsh9 Nov 4, 2024
3aca5b4
Update test_npu.py
liuxsh9 Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ray/_private/accelerators/npu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def get_current_node_num_accelerators() -> int:
logger.debug("Could not import AscendCL: %s", e)

try:
npu_files = glob.glob("/dev/davinci?")
npu_files = glob.glob("/dev/davinci[0-9]*")
return len(npu_files)
except Exception as e:
logger.debug("Failed to detect number of NPUs: %s", e)
Expand Down
4 changes: 2 additions & 2 deletions python/ray/tests/accelerators/test_npu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
def test_autodetect_num_npus(mock_glob):
with patch.dict(sys.modules):
sys.modules["acl"] = None
mock_glob.return_value = [f"/dev/davinci{i}" for i in range(4)]
assert Accelerator.get_current_node_num_accelerators() == 4
mock_glob.return_value = [f"/dev/davinci{i}" for i in range(64)]
assert Accelerator.get_current_node_num_accelerators() == 64


@patch("glob.glob")
Expand Down