[RLlib] New API stack: On by default for BC/MARWIL/CQL. #48599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api_stack_on_by_default_ppo
…api_stack_on_by_default_ppo Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/utils/exploration/tests/test_curiosity.py
…api_stack_on_by_default_ppo Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # doc/source/rllib/doc_code/rllib_in_60s.py # rllib/algorithms/tests/test_env_runner_failures.py # rllib/utils/exploration/tests/test_curiosity.py
…api_stack_on_by_default_ppo Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/utils/exploration/tests/test_curiosity.py
…api_stack_on_by_default_bc_marwil_cql Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # doc/source/rllib/doc_code/rllib_on_ray_readme.py # rllib/algorithms/ppo/ppo.py # rllib/core/learner/tests/test_learner_group.py # rllib/examples/_docs/rllib_on_rllib_readme.py # rllib/execution/rollout_ops.py # rllib/tuned_examples/bc/cartpole_recording.py
…api_stack_on_by_default_bc_marwil_cql
…tack_on_by_default_bc_marwil_cql
…accumulation_of_results_in_algorithm Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/core/learner/tests/test_learner_group.py
sven1977
requested review from
simonsays1980,
scottjlee and
bveeramani
as code owners
sven1977
commented
Nov 6, 2024
| # `self.api_stack()` | ||
| self.enable_rl_module_and_learner = True | ||
| self.enable_env_runner_and_connector_v2 = True | ||
| self.api_stack( |
There was a problem hiding this comment.
We have to call this method here (unfortunately) to make sure a possibly old API stack exploration_config gets properly saved (and then restored if necessary).
simonsays1980
approved these changes
Nov 6, 2024
| @@ -108,19 +108,9 @@ def __init__(self, algo_class=None): | |||
|
|
|||
| # Changes to Algorithm's/SACConfig's default: | |||
|
|
|||
| # `.api_stack()` | |||
There was a problem hiding this comment.
Let's put the following in here for the offline algos:
self.dataset_num_iters_per_learner=1 if args.num_learners == 0 else None…api_stack_on_by_default_bc_marwil_cql
…api_stack_on_by_default_bc_marwil_cql
…api_stack_on_by_default_bc_marwil_cql
sven1977
added
the
rllib-oldstack-cleanup
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…48599) Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…48599) Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API stack: On by default for BC/MARWIL/CQL.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.