Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Allow user to specify schema for write_parquet #48631

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[Data] Allow user to specify schema for write_parquet #48631

merged 1 commit into from
Nov 7, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Related issue number

Fixes #48630

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
c57fc4b 
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani enabled auto-merge (squash) November 7, 2024 19:32
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 7, 2024
@bveeramani bveeramani merged commit a20c7bc into master Nov 7, 2024
6 checks passed
@bveeramani bveeramani deleted the parquet-datasink-schema branch November 7, 2024 20:26
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
[Data] Allow user to specify schema for write_parquet (ray-project#…
11d8151 
…48631)

Fixes ray-project#48630

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@bveeramani @mohitjain2504
[Data] Allow user to specify schema for write_parquet (ray-project#…
f77ec0b 
…48631)

Fixes ray-project#48630

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@raulchen raulchen Awaiting requested review from raulchen

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@omatthew98 omatthew98 Awaiting requested review from omatthew98

@alexeykudinkin alexeykudinkin Awaiting requested review from alexeykudinkin

@srinathk10 srinathk10 Awaiting requested review from srinathk10

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data] Can't specify schema for write_parquet
2 participants
@bveeramani @scottjlee