-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib - Offline RL] Allow incomplete SampleBatch
data and fully compressed observations.
#48699
Merged
sven1977
merged 4 commits into
ray-project:master
from
simonsays1980:offline-rl-map-sample-batches-with-incomplete-and-fully-compressed-data
Nov 25, 2024
Merged
[RLlib - Offline RL] Allow incomplete SampleBatch
data and fully compressed observations.
#48699
sven1977
merged 4 commits into
ray-project:master
from
simonsays1980:offline-rl-map-sample-batches-with-incomplete-and-fully-compressed-data
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d observations. Furthermore, enabled reading incomplete SampleBatch data (e.g. missing terminateds, truncateds, done, or next observations. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
simonsays1980
added
enhancement
Request for new feature and/or capability
actor-based-usecase
Issues when running large scale actor-based usecases.
rllib-offline-rl
Offline RL problems
rllib
RLlib related issues
and removed
actor-based-usecase
Issues when running large scale actor-based usecases.
labels
Nov 12, 2024
sven1977
reviewed
Nov 12, 2024
sven1977
reviewed
Nov 12, 2024
sven1977
reviewed
Nov 12, 2024
sven1977
reviewed
Nov 12, 2024
sven1977
reviewed
Nov 12, 2024
sven1977
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR! Thanks @simonsays1980!
A handful of nits and one question. Otherwise, good to go.
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
…ete-and-fully-compressed-data
…sts. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
sven1977
changed the title
[RLlib - Offline RL] - Allow incomplete
[RLlib - Offline RL] Allow incomplete Nov 25, 2024
SampleBatch
data and fully compressed observations.SampleBatch
data and fully compressed observations.
jecsand838
pushed a commit
to jecsand838/ray
that referenced
this pull request
Dec 4, 2024
…pressed observations. (ray-project#48699) Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
…pressed observations. (ray-project#48699) Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Request for new feature and/or capability
go
add ONLY when ready to merge, run all tests
rllib
RLlib related issues
rllib-newstack
rllib-offline-rl
Offline RL problems
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some users have observations in their old
SampleBatch
data that are fully compressed, i.e. compression is over all timesteps (instead of compressing each single observation in alist
). These observations cannot be read in the actual state of theOfflinePreLearner
. Furthermore, if experiences are incomplete,SingleAgentEpisode
s cannot be built.This PR suggests multiple small changes to the
_map_sample_batches_to_episodes
to enable reading oldSampleBatch
data with incomplete experiences and/or fully compressed observations.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.