Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Remove unused KubeRayNodeProvider._url method. #48714

Merged
merged 3 commits into from
Nov 15, 2024
Merged

[Refactor] Remove unused KubeRayNodeProvider._url method. #48714

merged 3 commits into from
Nov 15, 2024

Conversation

ltbringer
Copy link
Contributor

@ltbringer ltbringer commented Nov 13, 2024 •
edited
Loading

Why are these changes needed?

This PR removes an unused method (_url) from the KubeRayNodeProvider class.

Related issue number

NA

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ltbringer ltbringer requested review from hongchaodeng and a team as code owners November 13, 2024 01:30
@MortalHappiness MortalHappiness self-assigned this Nov 13, 2024
@MortalHappiness MortalHappiness added the kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side label Nov 13, 2024
@MortalHappiness
Copy link
Member

MortalHappiness commented Nov 15, 2024 •
edited
Loading

Hi. Please sign-off all your commits for the DCO check to pass.

Besides, I think we don't need this get_kubernetes_host help function anymore because the _url method has been removed. You can change the PR title to something like "refactor: Remove unused KubeRayNodeProvider._url method".

@ltbringer
refactor: unused method KubeRayNodeProvider._url
0a18892 
Signed-off-by: ltbringer <amresh.venugopal@wise.com>
@MortalHappiness MortalHappiness added the go add ONLY when ready to merge, run all tests label Nov 15, 2024
MortalHappiness
MortalHappiness approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MortalHappiness MortalHappiness changed the title refactor: kubernetes host abstracted as a helper function. [Refactor] Remove unused KubeRayNodeProvider._url method. Nov 15, 2024
@jjyao jjyao enabled auto-merge (squash) November 15, 2024 18:21
@jjyao jjyao merged commit 196a0ca into ray-project:master Nov 15, 2024
6 checks passed
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
@ltbringer @dentiny
[Refactor] Remove unused KubeRayNodeProvider._url method. (ray-proj…
8a8c6b2 
…ect#48714)

Signed-off-by: ltbringer <amresh.venugopal@wise.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MortalHappiness MortalHappiness MortalHappiness approved these changes

@jjyao jjyao jjyao approved these changes

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng hongchaodeng is a code owner

Assignees

@MortalHappiness MortalHappiness

Labels
go add ONLY when ready to merge, run all tests kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltbringer @MortalHappiness @jjyao