[Core] Support labels for ray.remote #48715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
changed the title
raulchen
approved these changes
Nov 19, 2024
python/ray/tests/test_advanced.py
Outdated
| assert { | ||
| lineage_reconstruction_tasks[0][0].name, | ||
| lineage_reconstruction_tasks[1][0].name, | ||
| } == {"task", "Actor.run"} |
There was a problem hiding this comment.
Is there a guarantee for the order?
There was a problem hiding this comment.
No guarantee for the order.
There was a problem hiding this comment.
then we should sort the results here?
There was a problem hiding this comment.
You mean in the test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Allows users to set labels for actors and tasks (we already support node labels):
ray.remote(_labels={"key1": "value1"})We start with private option but it should be a generally useful thing to be public in the future.For now it will be used by Data and
get_local_ongoing_lineage_reconstruction_tasks()API.Related issue number
Closes #48476
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.