[data] Sort with None #48750
Merged
[data] Sort with None #48750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
requested review from
scottjlee,
bveeramani,
raulchen,
stephanie-wang,
omatthew98,
alexeykudinkin and
srinathk10
as code owners
alexeykudinkin
approved these changes
Nov 15, 2024
| @@ -634,6 +633,10 @@ def key_fn(r): | |||
| else: | |||
| return (0,) | |||
|
|
|||
| def key_fn_with_null_sentinel(r): | |||
| values = key_fn(r) | |||
| return [NULL_SENTINEL if v is None else v for v in values] | |||
There was a problem hiding this comment.
Please add a comment elaborating what we're trying to achieve
This was referenced Dec 4, 2024
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
## Why are these changes needed? Adds a Sentinel value for making it possible to sort. Fixes ray-project#42142 ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds a Sentinel value for making it possible to sort.
Fixes #42142
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.