[RLlib] Make opencv-python-headless default over opencv-python #48776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturNiederfahrenhorst
changed the title
ArturNiederfahrenhorst
requested review from
sven1977 and
simonsays1980
as code owners
sven1977
reviewed
Nov 18, 2024
| @@ -5,7 +5,7 @@ | |||
| # Atari | |||
| ale_py==0.10.1 | |||
| imageio==2.34.2 | |||
| opencv-python==4.8.1.78 | |||
| opencv-python-headless==4.8.1.78 | |||
sven1977
approved these changes
Nov 18, 2024
ArturNiederfahrenhorst
force-pushed
the
opencv
branch
from
81f6147 to
030af7e
Compare
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
…roject#48776) ## Why are these changes needed? Make `opencv-python-headless` defeault requirement for RLlib/ This is necessary, because `opencv-python` may not work in many headless environments. Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make
opencv-python-headlessdefeault requirement for RLlib/This is necessary, because
opencv-pythonmay not work in many headless environments.