Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed limit on log sizes via sockets #48780

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mohitjain2504
Copy link
Contributor

@mohitjain2504 mohitjain2504 commented Nov 18, 2024

Why are these changes needed?

I was trying to read the logs of a Ray job via the sockets. Despite using sockets, and ensuring that we poll the socket on regular intervals, we realised that the socket closes after the transfer of exactly 4096KBs. After multiple trials, realised that its the logs for the socket that closes after this limit. Needed to ensure that sockets are not closed for long running heavy jobs.

Related issue number

Checks

  • [-] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
@mohitjain2504 mohitjain2504 changed the title removed limit on log sizes removed limit on log sizes via sockets Nov 18, 2024
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants