Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix broken APPO release test (config error). #48869

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[RLlib] Fix broken APPO release test (config error). #48869

merged 1 commit into from
Nov 22, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 22, 2024 •
edited
Loading

Fix broken APPO release test (config error).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
fc4c7b3 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added rllib RLlib related issues rllib-newstack labels Nov 22, 2024
simonsays1980
simonsays1980 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 enabled auto-merge (squash) November 22, 2024 17:28
@sven1977 sven1977 added the go add ONLY when ready to merge, run all tests label Nov 22, 2024
@aslonnie aslonnie disabled auto-merge November 22, 2024 18:34
@aslonnie aslonnie merged commit 365266d into ray-project:master Nov 22, 2024
4 of 6 checks passed
@aslonnie aslonnie mentioned this pull request Nov 22, 2024
Closed
@sven1977 sven1977 deleted the fix_broken_appo_release_test branch November 24, 2024 20:35
jecsand838 pushed a commit to jecsand838/ray that referenced this pull request Dec 4, 2024
@sven1977 @jecsand838
[RLlib] Fix broken APPO release test (config error). (ray-project#48869)
bc0a099 
Fix broken APPO release test (config error).

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
@sven1977 @dentiny
[RLlib] Fix broken APPO release test (config error). (ray-project#48869)
c972ee0 
Fix broken APPO release test (config error).

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

Assignees

@simonsays1980 simonsays1980

@aslonnie aslonnie

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-newstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @simonsays1980 @aslonnie