Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Raise ValueError when the data sort key is None #48969

Merged
merged 5 commits into from
Dec 3, 2024
Merged

[Data] Raise ValueError when the data sort key is None #48969

merged 5 commits into from
Dec 3, 2024

Conversation

Superskyyy
Copy link
Contributor

@Superskyyy Superskyyy commented Nov 27, 2024 •
edited
Loading

Why are these changes needed?

Closes: #48926 #48927

Related issue number

Checks

  • [x ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Superskyyy
Raise ValueError when the sort key is None
ea2523b 
Signed-off-by: Superskyyy <yihaochen@apache.org>
@Superskyyy
Add a note on the key param
0c9d533 
Signed-off-by: Superskyyy <yihaochen@apache.org>
@Superskyyy Superskyyy mentioned this pull request Nov 27, 2024
Closed
@Superskyyy Superskyyy changed the title Raise ValueError when the data sort key is None [Data] Raise ValueError when the data sort key is None Nov 27, 2024
@Superskyyy
Remove test file
a648a35 
Signed-off-by: Superskyyy <yihaochen@apache.org>
@richardliaw richardliaw self-assigned this Nov 30, 2024
@richardliaw richardliaw added the go add ONLY when ready to merge, run all tests label Dec 2, 2024
richardliaw and others added 2 commits December 2, 2024 15:13
@richardliaw
fix
94f628c 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@raulchen
Update dataset.py
b09aa38 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen enabled auto-merge (squash) December 3, 2024 01:51
@raulchen raulchen merged commit a2f054b into ray-project:master Dec 3, 2024
6 checks passed
jecsand838 pushed a commit to jecsand838/ray that referenced this pull request Dec 4, 2024
@Superskyyy @richardliaw
@raulchen @jecsand838
[Data] Raise ValueError when the data sort key is None (ray-project#4…
1cf6452 
…8969)

Closes: ray-project#48926
ray-project#48927
<!-- Please give a short summary of the change and the problem this
solves. -->

Signed-off-by: Superskyyy <yihaochen@apache.org>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
@Superskyyy @richardliaw
@raulchen @dentiny
[Data] Raise ValueError when the data sort key is None (ray-project#4…
9b6982b 
…8969)

Closes: ray-project#48926
ray-project#48927
<!-- Please give a short summary of the change and the problem this
solves. -->


Signed-off-by: Superskyyy <yihaochen@apache.org>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
@wingkitlee0 wingkitlee0 mentioned this pull request Dec 11, 2024
Open
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
@Superskyyy @richardliaw
@raulchen @ujjawal-khare
[Data] Raise ValueError when the data sort key is None (ray-project#4…
cc20991 
…8969)

Closes: ray-project#48926
ray-project#48927
<!-- Please give a short summary of the change and the problem this
solves. -->

Signed-off-by: Superskyyy <yihaochen@apache.org>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@alexeykudinkin alexeykudinkin alexeykudinkin approved these changes

@scottjlee scottjlee Awaiting requested review from scottjlee

@bveeramani bveeramani Awaiting requested review from bveeramani

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@omatthew98 omatthew98 Awaiting requested review from omatthew98

@srinathk10 srinathk10 Awaiting requested review from srinathk10

Assignees

@richardliaw richardliaw

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data] Default value of key in sort(key=None) raises IndexError
4 participants
@Superskyyy @alexeykudinkin @raulchen @richardliaw