-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade py-spy to 0.4.0 for py312 support #48978
Conversation
Signed-off-by: Alan Guo <aguo@anyscale.com>
python/requirements_compiled.txt
Outdated
@@ -1519,7 +1519,7 @@ py-cpuinfo==9.0.0 | |||
# via deepspeed | |||
py-partiql-parser==0.5.0 | |||
# via moto | |||
py-spy==0.3.14 | |||
py-spy==0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, you can upgrade this in python/requirements.txt files i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can copy the generated content for this PR here https://ray-ci-artifact-pr-public.s3.amazonaws.com/bc9fbdaa9cc5d971bca51db672e7692b91dc316a/tmp/artifacts/requirements_compiled.txt
Signed-off-by: Alan Guo <aguo@anyscale.com>
python/requirements_compiled.txt
Outdated
@@ -1519,7 +1519,7 @@ py-cpuinfo==9.0.0 | |||
# via deepspeed | |||
py-partiql-parser==0.5.0 | |||
# via moto | |||
py-spy==0.3.14 | |||
py-spy==0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this constraint file is used in py39 test environments, and I think this can lead to failures. I think we need to have separate requirement constraint files for different python versions in the long run. in the short run, maybe py-spy
can be treated as a special case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the changes in
python/setup.py
andpython/requirements.txt
files are okay - the constraint file update probably has issues.
how is py-spy
being tested, and are they tested on different python versions?
In my manual testing, the wheels still seem to have v0.3.14. Not sure what I need to do differently here. There are automated tests in |
could you tell me how you did the manual testing? |
I downloaded the wheel and launched a Anyscale workspace with that wheel installed. |
(looks good from my side for setup.py) |
python/requirements_compiled.txt
Outdated
@@ -1519,7 +1519,7 @@ py-cpuinfo==9.0.0 | |||
# via deepspeed | |||
py-partiql-parser==0.5.0 | |||
# via moto | |||
py-spy==0.3.14 | |||
py-spy==0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can copy the generated content for this PR here https://ray-ci-artifact-pr-public.s3.amazonaws.com/bc9fbdaa9cc5d971bca51db672e7692b91dc316a/tmp/artifacts/requirements_compiled.txt
Signed-off-by: Alan Guo <aguo@anyscale.com>
do we currently run all tests on all python versions? Is there a way to add configure a test file to run on python 3.12? |
@alanwguo you can add the |
Signed-off-by: Alan Guo <aguo@anyscale.com>
@@ -1519,7 +1519,7 @@ py-cpuinfo==9.0.0 | |||
# via deepspeed | |||
py-partiql-parser==0.5.0 | |||
# via moto | |||
py-spy==0.3.14 | |||
py-spy==0.4.0 ; python_version < "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we just upgrade py-spy to 0.4.0, like for images of all python versions now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is reasonable behavior:
For our images, we use 0.4.0 out of the box.
For users installing ray themselves, we won't enforce 0.4.0 unless python 3.12 is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
wonder why we did not upgrade py-spy
earlier.. like was there something blocking us to do so? seems like a simple change based on this PR..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wasn't aware of 0.4.0's release. Which was released this november. I just saw someone comment that 0.4.0 had python 3.12 support so I updated after seeing that.
Why are these changes needed?
py-spy 0.4.0 has support for python 3.12.
Related issue number
Fixes #47388
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.