[RLlib] Add comments to example files for templates. #48988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
changed the title
sven1977
reviewed
Dec 2, 2024
sven1977
reviewed
Dec 2, 2024
sven1977
reviewed
Dec 2, 2024
sven1977
reviewed
Dec 2, 2024
sven1977
reviewed
Dec 2, 2024
| env_to_module_connector=_make_env_to_module_connector, | ||
| ) | ||
| .training( | ||
| learner_connector=_make_learner_connector, | ||
| train_batch_size_per_learner=4000, # 5000 on old yaml example | ||
| minibatch_size=128, # 500 on old yaml example | ||
| train_batch_size_per_learner=4000, |
Signed-off-by: Sven Mika <sven@anyscale.io>
sven1977
approved these changes
Dec 2, 2024
sven1977
added
rllib
jecsand838
pushed a commit
to jecsand838/ray
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
Signed-off-by: hjiang <dentinyhao@gmail.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In order to extract sections of the given files in a programmatic way, we inject comments in this PR.
This enables us to separate the declaration of the config and the imports from the rest.