Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib; docs] Fix RLlib main index page (code in multi-agent tab wrong). #49037

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[RLlib; docs] Fix RLlib main index page (code in multi-agent tab wrong). #49037

merged 1 commit into from
Dec 4, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 3, 2024 •
edited
Loading

Fix RLlib main index page (code in multi-agent tab wrong).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack rllib-multi-agent An RLlib multi-agent related problem. labels Dec 3, 2024
@sven1977 sven1977 enabled auto-merge (squash) December 3, 2024 14:02
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 3, 2024
sven1977
sven1977 commented Dec 3, 2024
View reviewed changes
doc/source/rllib/index.rst
@@ -193,8 +193,14 @@ click the dropdowns below:
| |
| .. code-block:: python |
| |
| config.environment("CartPole-v1") # Classic Control |
| config.environment("ale_py:ALE/Pong-v5") # Atari |
| from ray.rllib.examples.envs.classes.multi_agent import MultiAgentCartPole |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<--- this was the wrong code

@sven1977 sven1977 changed the title [RLlib; docs; fix] Fix RLlib main index page (code in multi-agent tab wrong). [RLlib; docs] Fix RLlib main index page (code in multi-agent tab wrong). Dec 3, 2024
@sven1977 sven1977 disabled auto-merge December 3, 2024 19:57
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 4, 2024
simonsays1980
simonsays1980 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 merged commit 19f9d88 into ray-project:master Dec 4, 2024
5 of 6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
@sven1977 @ujjawal-khare
[RLlib; docs] Fix RLlib main index page (code in multi-agent tab wron…
a4178a3 
…g). (ray-project#49037)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-multi-agent An RLlib multi-agent related problem. rllib-newstack tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980