Add instance variables to many default dashboard graphs #49174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykudinkin
approved these changes
Dec 10, 2024
| @@ -88,7 +88,7 @@ def max_plus_pending(max_resource, pending_resource): | |||
| Panel( | |||
| id=33, | |||
| title="Scheduler Actor State", | |||
| description="Current number of actors in a particular state.\n\nState: the actor state, as described by rpc::ActorTableData proto in gcs.proto.", | |||
| description='Note: not impacted by "Instance" variable.\n\nCurrent number of actors in a particular state.\n\nState: the actor state, as described by rpc::ActorTableData proto in gcs.proto.', | |||
There was a problem hiding this comment.
@alanwguo can you please file a ticket to fix it in Core and add a TODO here?
There was a problem hiding this comment.
looks like, this is already avialable with the NodeAddress label. Updated the graphs here
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Dec 12, 2024
…ay-project#49174) Signed-off-by: Alan Guo <aguo@anyscale.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
…ay-project#49174) Signed-off-by: Alan Guo <aguo@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It's confusing that there is an "Instance" drop down in Grafana but many of the graphs don't respect it.
THis changes it so most graphs respect it and puts a note in the description for those that do not.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.