Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; docs] Adjust the documentation of the default API stack and replace 'rollouts' with 'env_runners'. #49304

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Dec 17, 2024

…llouts' with 'env_runners' in 'Getting Started'.

Why are these changes needed?

RLlib's default API stack is now the new API stack, however, the documentation still tells the other way around. This PR makes some primer adjustments. For the long run we need to rewrite the pages fully and replace references therein.

Related issue number

Closes #49076 #49073

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…llouts' with 'env_runners' in 'Getting Started'.

Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
@simonsays1980 simonsays1980 added rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack labels Dec 17, 2024
@simonsays1980 simonsays1980 marked this pull request as ready for review December 17, 2024 11:35
@sven1977 sven1977 changed the title [RLlib] Adjust the documentation of the default API stack and replace 'rollouts' with 'env_runners'. [RLlib; docs] Adjust the documentation of the default API stack and replace 'rollouts' with 'env_runners'. Dec 18, 2024
@sven1977 sven1977 enabled auto-merge (squash) December 18, 2024 09:41
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 18, 2024
@@ -25,7 +25,7 @@ RLlib classes and code to RLlib's new API stack.
Change your AlgorithmConfig
---------------------------

RLlib turns off the new API stack by default for all RLlib algorithms. To activate it, use the `api_stack()` method
RLlib turns on the new API stack by default for all RLlib algorithms. To deactivate it, use the `api_stack()` method
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @simonsays1980

@sven1977 sven1977 merged commit 836b4d2 into ray-project:master Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-docs-or-examples Issues related to RLlib documentation or rllib/examples rllib-newstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLlib] New API stack is enabled by default, but "New API stack migration guide" says the opposite
2 participants