-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib; docs] Docs do-over (new API stack): RLModules vol 02; Major cleanups, SAC/DQN default RLModules, QNetAPI, remove noisy nets from DQN. #49368
[RLlib; docs] Docs do-over (new API stack): RLModules vol 02; Major cleanups, SAC/DQN default RLModules, QNetAPI, remove noisy nets from DQN. #49368
Conversation
…edo_rl_module_002
…_redo_rl_module_001_default_rl_modules
…edo_rl_module_002
…_redo_rl_module_002
…edo_rl_module_002
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great PR. As we do not name DQN anymore RainbowDQN gthe removal of NoisyNets looks good.
|
||
@num_cpus_for_local_worker.setter | ||
def num_cpus_for_local_worker(self, value): | ||
deprecation_warning( | ||
old="AlgorithmConfig.num_cpus_for_local_worker", | ||
new="AlgorithmConfig.num_cpus_for_main_process", | ||
error=False, | ||
error=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! So much cleanup!
|
||
|
||
@PublicAPI(stability="alpha") | ||
class QNetAPI(abc.ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This API was missing, yet.
Docs do-over (new API stack): RLModules vol 02
QNetAPI
(for both DQN- and SACRLModules), requiring the user to implement thecompute_q_values
and (optionally)compute_advantage_distribution
methods (for dueling-Q).ParameterNoise
Exploration
component.Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.