Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train v2] Add __init__.py to train/v2/_internal/logging #49467

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

Make this directory part of the Ray Train module. Otherwise, this results in module not found errors when installing ray normally.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@justinvyu justinvyu enabled auto-merge (squash) December 27, 2024 23:19
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 27, 2024
@justinvyu justinvyu merged commit 528014c into ray-project:master Dec 28, 2024
6 checks passed
@justinvyu justinvyu deleted the train_logging_module branch December 28, 2024 00:11
justinvyu added a commit to justinvyu/ray that referenced this pull request Dec 30, 2024
…ject#49467)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
srinathk10 pushed a commit that referenced this pull request Jan 3, 2025
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants