[RLlib] Add MetricsLogger to connector- and pipeline-calls.
#49693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
added
rllib
simonsays1980
approved these changes
Jan 7, 2025
| batch={}, | ||
| episodes=episodes_flat, | ||
| shared_data={}, | ||
| metrics=self.metrics, |
| @@ -99,14 +99,16 @@ def __call__( | |||
| # Loop through connector pieces and call each one with the output of the | |||
| # previous one. Thereby, time each connector piece's call. | |||
| for connector in self.connectors: | |||
| timer = self.timers[str(connector)] | |||
| with timer: | |||
| with metrics.log_time( | |||
There was a problem hiding this comment.
Nice implementation!
| **kwargs, | ||
| ) | ||
|
|
||
| # Log the sum of lengths of all episodes outgoing. | ||
| if metrics: |
There was a problem hiding this comment.
Sweet! I will log similar values in the buffers.
| @@ -258,6 +258,9 @@ def __call__(self, batch: Dict[str, np.ndarray]) -> Dict[str, List[EpisodeType]] | |||
| batch={}, | |||
| episodes=episodes, | |||
| shared_data={}, | |||
| # TODO (sven): Add MetricsLogger to non-Learner components that have a | |||
There was a problem hiding this comment.
Good comment! I can take a look at the PreLearner and Offline RL in general, if you want me to.
…metrics_to_connector_pipelines
…metrics_to_connector_pipelines
…metrics_to_connector_pipelines
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 9, 2025
…oject#49693) Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
HYLcool
pushed a commit
to HYLcool/ray
that referenced
this pull request
Jan 13, 2025
…oject#49693) Signed-off-by: lielin.hyl <lielin.hyl@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MetricsLoggerto connector- and pipeline-calls.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.