Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alarm extension #6441

Closed
wants to merge 12 commits into from
Closed

Add alarm extension #6441

wants to merge 12 commits into from

Conversation

aurnik
Copy link

@aurnik aurnik commented May 9, 2023

Description

This extension parses text passed as an argument to create alarms. Alarms can be set using a specific date and time or using a duration.

Screencast

Creating an alarm
Viewing a list of alarms

Checklist

aurnik added 3 commits May 9, 2023 14:07
- Temporarily remove images
- Change 'a' tag to markdown link
- Update formatting
- Initial Commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label May 9, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented May 9, 2023

Congratulations on your new Raycast extension! 🚀

We will aim to make the initial review within five working days. Once the PR is approved and merged, the extension will be available on our Store.

aurnik added 7 commits May 9, 2023 14:33
- Merge branch 'contributions/merge-1683668387303584000'
- Pull contributions
- Sort alarms by time
- Update images
@pernielsentikaer
Copy link
Collaborator

Hi @aurnik 👋

Thanks for your contribution 🔥 It looks like we have something very similar in the store already, could you check that out?

@pernielsentikaer pernielsentikaer self-assigned this May 23, 2023
@aurnik
Copy link
Author

aurnik commented May 24, 2023

Hey @pernielsentikaer thanks for getting back to me -- yes I did see that extension but thought this provided some useful differences:

  1. The mentioned extension uses a background service running on a 1 minute interval to set its notifications, whereas this one schedules the notification using a shell command. This avoids the regularly running background service and notifies the user at the exact time they've scheduled.
  2. This extension allows creating alarms that don't have a "topic", such as setting an alarm for 15 minutes (and these are created without going to a separate view using command arguments)
  3. This has the additional setting to use dialog boxes instead of notifications (can be seen even when Focus is on)

It seemed like adding these to that extension would fundamentally change the design choices that the developer made, so I rolled this out separately. I'm open to any feedback though, appreciate your time.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

alarm 2023-06-06 at 11 52 27
  • Why is refresh.ts necessary, I can't figure out what it brings, can you clarify that for me 🙂

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Jun 20, 2023
@raycastbot
Copy link
Collaborator

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

@raycastbot raycastbot closed this Jun 27, 2023
@aurnik
Copy link
Author

aurnik commented Mar 21, 2024

✅ Fixed

✅ Fixed

  • Would be nice with an icon here 🙂

Which part are you referring to? At least in that photo, I'm seeing icons for the extension itself as well as each list item.

  • Why is refresh.ts necessary, I can't figure out what it brings, can you clarify that for me 🙂

Because this extension schedules the timers instead of constantly checking if the time is up, this file handles the actual scheduling. It only needs to be run once, but it does need to happen in the background or else the user would need to run a command every time Raycast was started in order to reschedule alarms . The interval could be anything though. If there's a better way to do this, I'm happy to change it.

Also, I posted in Slack but I'm unable to update this with npm run publish. Do I need to close this and create a new PR?

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Mar 21, 2024
@mil3na
Copy link
Contributor

mil3na commented Mar 26, 2024

Hey @aurnik ! Is this PR ready for re-review? Are you still having issues with the publish command?

@aurnik
Copy link
Author

aurnik commented Mar 28, 2024

@mil3na Thanks for getting back, and yes I'm still unable to use the publish command.

This was my message from the Slack group:

Hey team, I'm trying to publish updates to an extension I submitted some time ago, and I've updated my fork of raycast-extensions but now when I try to run npm run publish it tells me I need to pull new contributions, and when I try doing that I get an error fatal: Not possible to fast-forward, aborting. from the command git pull origin ext/alarm --ff-only. Any advice on how to move forward?

The git pull command is a part of npx @raycast/api@latest pull-contributions, and this is my repo for the extension on its own.

@pernielsentikaer
Copy link
Collaborator

I just asked my colleagues to have a look on the thread so we can continue here 🙂

@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Apr 17, 2024
@pernielsentikaer
Copy link
Collaborator

Pinged in Slack, are you still having the issue @aurnik

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Apr 18, 2024
@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label May 2, 2024
@raycastbot
Copy link
Collaborator

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

@raycastbot raycastbot closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions status: stalled Stalled due inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants