-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alarm extension #6441
Add alarm extension #6441
Conversation
- Temporarily remove images - Change 'a' tag to markdown link - Update formatting - Initial Commit
Congratulations on your new Raycast extension! 🚀 We will aim to make the initial review within five working days. Once the PR is approved and merged, the extension will be available on our Store. |
- Merge branch 'contributions/merge-1683668387303584000' - Pull contributions - Sort alarms by time - Update images
Hi @aurnik 👋 Thanks for your contribution 🔥 It looks like we have something very similar in the store already, could you check that out? |
Hey @pernielsentikaer thanks for getting back to me -- yes I did see that extension but thought this provided some useful differences:
It seemed like adding these to that extension would fundamentally change the design choices that the developer made, so I rolled this out separately. I'm open to any feedback though, appreciate your time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Thanks for your contribution 💪
I have now tested your extension, and I have some feedback ready for you:
-
The command
List Alarms
suffers from Empty state flicker -
I would add a confirmAlert before deleting
-
Would be nice with an icon here 🙂
- Why is
refresh.ts
necessary, I can't figure out what it brings, can you clarify that for me 🙂
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
This issue has been automatically closed due to inactivity. Feel free to comment in the thread when you're ready to continue working on it 🙂 You can also catch us in Slack if you want to discuss this. |
✅ Fixed
✅ Fixed
Which part are you referring to? At least in that photo, I'm seeing icons for the extension itself as well as each list item.
Because this extension schedules the timers instead of constantly checking if the time is up, this file handles the actual scheduling. It only needs to be run once, but it does need to happen in the background or else the user would need to run a command every time Raycast was started in order to reschedule alarms . The interval could be anything though. If there's a better way to do this, I'm happy to change it. Also, I posted in Slack but I'm unable to update this with |
Hey @aurnik ! Is this PR ready for re-review? Are you still having issues with the publish command? |
@mil3na Thanks for getting back, and yes I'm still unable to use the publish command. This was my message from the Slack group:
The git pull command is a part of |
I just asked my colleagues to have a look on the thread so we can continue here 🙂 |
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
Pinged in Slack, are you still having the issue @aurnik |
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
This issue has been automatically closed due to inactivity. Feel free to comment in the thread when you're ready to continue working on it 🙂 You can also catch us in Slack if you want to discuss this. |
Description
This extension parses text passed as an argument to create alarms. Alarms can be set using a specific date and time or using a duration.
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder