Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat-Cargo.lock #705

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Update compat-Cargo.lock #705

merged 2 commits into from
Nov 7, 2019

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Nov 7, 2019

I've noticed that #704 uses old compat lockfile, which is strange, given that it changes Cargo.lock.

What happens here is that cargo writes new compat lockfile during CI.

That means that CI might break randomly, if rayon's dependency is published with the same major version, but different MSRV

With this PR, CI will break deterministically if you change Cargo.toml and don't update compat-Cargo.lock.

Not sure if this actually makes sense :)

Previously, compat-Cargo.lock could have been updated during CI, if
Cargo.toml is changed. This can lead to spurious build failures when
testing MSRV, because not all dependencies are effectively locked.
@cuviper
Copy link
Member

cuviper commented Nov 7, 2019

Good catch, thank you!

bors r+

bors bot added a commit that referenced this pull request Nov 7, 2019
705: Update compat-Cargo.lock r=cuviper a=matklad

I've noticed that #704 uses old compat lockfile, which is strange, given that it changes Cargo.lock.

What happens here is that cargo writes new compat lockfile during CI.

That means that CI might break randomly, if rayon's dependency is published with the same major version, but different MSRV

With this PR, CI will break deterministically if you change Cargo.toml and don't update compat-Cargo.lock.

Not sure if this actually makes sense :)

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 7, 2019

@bors bors bot merged commit 54c0b0d into rayon-rs:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants