-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production Dark Mode is glitchy #9
Comments
Has this problem been solved yet? |
This feature is work fine in dev btw. But by somehow it's not working for production build. Video (https://youtu.be/dDN3fRGaOkc) What we got now is Context properly sent in production but like I said it doesn't change any component style. ExampleTook https://github.com/rayriffy/rayriffy-h/blob/master/src/pages/g/index.js Context Card color are being controlled at line 68 When switch on Dark Mode button it changed |
The solution is here! It seems everything in production is working fine but React did not update DOM on client-side Workaround this issue is to waiting everything is rendered first before mounting into client. This issue will be closed and refactoring will be issued soon. |
Description
This application is mainly controlling Dark Mode in App component saving state into
LocalStorage
and sharing variables via AppContextLooks like context is actually sent into sub-component (see logged result at image below) but style is never got updated when navigate to another page in production and I have no idea why.
Expectation
Reality
The text was updated successfully, but these errors were encountered: