Win32: resolve some symbols re-definition of windows.h in glfw3native.h #2643
Conversation
This reflects GLFW's fix: glfw/glfw#1348 This enables to build with a external GLFW containing the following fix: * glfw/glfw@05f6c13 Currently, glfw3native.h of the internal GLFW is customized at raysan5@2feea87 This fix is compatible with the current customized glfw3native.h. This fix enables us to update it to the latest and remove the customization.
|
@daipom Oh! That's great! I lost track of that issue long ago! Nice to see a review has been implemented! It will also make it easy to update GLFW! |
|
@daipom Thanks for the update! Merged! |
|
Thanks for merging! In fact, we are developing IME support in GLFW to allow Japanese input, etc. We would like to use this feature in raylib too once we have finished developing it in GLFW. Please let me discuss this with you again on issues and PR! |
That's amazing! I've been asked several times to support it on raylib! We can add that feature to raylib when ready! Please note that raylib GLFW is not updated at the moment, I was waiting for the 3.4 official release of the library but it seems it's taking longer than expected... |
|
Thanks so much! We are trying to get that feature into GLFW v3.4! |
This reflects GLFW's fix: glfw/glfw#1348
Currently, we can't build raylib with an external GLFW in Win32
since some symbol re-definition errors occur.
The internal GLFW in raylib seems to avoid this problem by customizing
glfw3native.h: 2feea87This fix enables building with an external GLFW in Win32 without any customization,
if it contains the fix of glfw/glfw#1348.
This fix is compatible with the current internal GLFW too.
If we update the internal GLFW to the latest before we merge this branch,
we don't need the commit: 6609c68.
In that case, I will remove that commit from this branch.