Use RL_QUADS/RL_TRIANGLES for single-pixel drawing #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses problem mentioned in raysan5#2744 (comment) (in short: when drawing pixels using DrawPixel{,V} in camera mode, upscaled pixel becomes a line instead of bigger pixel)
hatkidchan
commented
Oct 11, 2022
hatkidchan
commented
Oct 11, 2022
|
Test build was made on Linux, I don't really have a Windows machine on me anymore, so it'd be nice to check if it works here. Though I doubt that it'd be much different. Comparison between old and new versions (colors were added to differentiate between normal and camera view but other than that it's the same as in that issue comment): |
|
@hatkidchan Thank you very much for the review and the quick PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses problem mentioned in #2744 (comment) (in short: when drawing pixels using
DrawPixel/DrawPixelVin camera mode, upscaled pixel becomes a line instead of bigger pixel).