[core] rcamera bugfix - messed up orientation #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this addresses #2660 and maybe #2661 though I'm not sure. Maybe I was just misusing the library.
Moving the assignment of the camera's y value to
playerEyesPositionbefore the projection matrix was applied a.) made more sense to me and b.) fixed a weird issue I was having with v4.2.0 where mouse movement would move the player in a very small range if the playerEyesPosition ever changed from what it was initialized at.I am on linux and have only tested the build on linux. Works well, though, and resolved my issues.