Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[raudio] Rewritten ExportWaveAsCode() file saving to be more like rtextures ExportImageAsCode() #3013

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

RadsammyT
Copy link
Contributor

The current ExportWaveAsCode() has some various bugs/inconsistencies:

The data array name will list the entire path to the file. I don't know if ':', '/', and '\' are valid symbols in C var names but I made it so only the file name without its path and extension are listed. Also, note the missing file names before the wave data information preprocessor defines, and the unusual data array var name casing.
Before:
vwM5Kir2Xe

After:
Xpqc0rfUQ3

Review `raudio.c`: rewritten `ExportWaveAsCode()` to be more like rtextures.c `ExportImageAsCode()'
accidentally inserted a tab somewhere. corrected it.
@raysan5 raysan5 merged commit e2da32e into raysan5:master Apr 15, 2023
@raysan5
Copy link
Owner

raysan5 commented Apr 15, 2023

@RadsammyT Thanks for the review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants